javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 22:17:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(types): use proper variable names

Browse Source
This commit is contained in:
Andrew
2015-03-25 21:08:08 -06:00
parent c9159654e7
commit 6f035ed1a8
1 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/components/aside/extensions/types/types.js
View File

@ -2,22 +2,22 @@ import {Aside} from '../../aside';
// TODO use setters instead of direct dom manipulation // TODO use setters instead of direct dom manipulation
let asideManipulator = { let asideManipulator = {
setSliding(is) { setSliding(sliding) {
this.aside.domElement.classList[is ? 'add' : 'remove']('no-transition'); this.aside.domElement.classList[sliding ? 'add' : 'remove']('no-transition');
}, },
setOpen(is) { setOpen(open) {
this.aside.domElement.classList[is ? 'add' : 'remove']('open'); this.aside.domElement.classList[open ? 'add' : 'remove']('open');
}, },
setTransform(t) { setTransform(t) {
this.aside.domElement.style.transform = t; this.aside.domElement.style.transform = t;
} }
} }
let contentManipulator = { let contentManipulator = {
setSliding(is) { setSliding(sliding) {
this.aside.content.domElement.classList[is ? 'add' : 'remove']('no-transition'); this.aside.content.domElement.classList[sliding ? 'add' : 'remove']('no-transition');
}, },
setOpen(is) { setOpen(open) {
this.aside.content.domElement.classList[is ? 'add' : 'remove']( this.aside.content.domElement.classList[open ? 'add' : 'remove'](
`aside-open-${this.aside.side}` `aside-open-${this.aside.side}`
) )
}, },
@ -40,11 +40,11 @@ class AsideType {
} }
export class AsideTypeOverlay extends AsideType { export class AsideTypeOverlay extends AsideType {
setSliding(is) { setSliding(sliding) {
asideManipulator.setSliding.call(this, is); asideManipulator.setSliding.call(this, sliding);
} }
setOpen(is) { setOpen(open) {
asideManipulator.setOpen.call(this, is); asideManipulator.setOpen.call(this, open);
} }
setTransform(t) { setTransform(t) {
asideManipulator.setTransform.call(this, t); asideManipulator.setTransform.call(this, t);
@ -52,13 +52,13 @@ export class AsideTypeOverlay extends AsideType {
} }
export class AsideTypePush extends AsideType { export class AsideTypePush extends AsideType {
setSliding(is) { setSliding(sliding) {
asideManipulator.setSliding.call(this, is); asideManipulator.setSliding.call(this, sliding);
contentManipulator.setSliding.call(this, is); contentManipulator.setSliding.call(this, sliding);
} }
setOpen(is) { setOpen(open) {
asideManipulator.setOpen.call(this, is); asideManipulator.setOpen.call(this, open);
contentManipulator.setOpen.call(this, is); contentManipulator.setOpen.call(this, open);
} }
setTransform(t) { setTransform(t) {
asideManipulator.setTransform.call(this, t); asideManipulator.setTransform.call(this, t);
@ -67,12 +67,12 @@ export class AsideTypePush extends AsideType {
} }
export class AsideTypeReveal extends AsideType { export class AsideTypeReveal extends AsideType {
setSliding(is) { setSliding(sliding) {
contentManipulator.setSliding.call(this, is); contentManipulator.setSliding.call(this, sliding);
} }
setOpen(is) { setOpen(sliding) {
asideManipulator.setOpen.call(this, is); asideManipulator.setOpen.call(this, sliding);
contentManipulator.setOpen.call(this, is); contentManipulator.setOpen.call(this, sliding);
} }
setTransform(t) { setTransform(t) {
contentManipulator.setTransform.call(this, t); contentManipulator.setTransform.call(this, t);