javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(theming): remove Sass default flags (#29401)

Browse Source 
Issue number: N/A

---------

## What is the current behavior?
Currently, every Sass variable in Ionic has the `!default` flag added to
the end.

From the [Sass variables
documentation](https://sass-lang.com/documentation/variables/):

> Normally when you assign a value to a variable, if that variable
already had a value, its old value is overwritten. But if you’re writing
a Sass library, you might want to allow your users to configure your
library’s variables before you use them to generate CSS.
> 
> To make this possible, Sass provides the `!default` flag. This assigns
a value to a variable only if that variable isn’t defined or its value
is [null](https://sass-lang.com/documentation/values/null). Otherwise,
the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to
rebuild Ionic Framework using their own values. In the latest versions
of Ionic Framework, this is not possible.

## What is the new behavior?
Removes the `!default` flag from all Sass variables.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

-------

Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com>
This commit is contained in:
Liam DeBeasi
2024-04-25 15:59:10 -04:00
committed by GitHub
parent 0873dc2ffb
commit 6e8bf4914f
127 changed files with 1301 additions and 1301 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/src/components/toolbar/toolbar.ios.vars.scss
View File

@ -17,24 +17,24 @@ $toolbar-order-ios: (
);
/// @prop - Minimum height of the toolbar
$toolbar-ios-min-height: 44px !default;
$toolbar-ios-min-height: 44px;
/// @prop - Padding top of the toolbar
$toolbar-ios-padding-top: 3px !default;
$toolbar-ios-padding-top: 3px;
/// @prop - Padding end of the toolbar
$toolbar-ios-padding-end: 4px !default;
$toolbar-ios-padding-end: 4px;
/// @prop - Padding bottom of the toolbar
$toolbar-ios-padding-bottom: $toolbar-ios-padding-top !default;
$toolbar-ios-padding-bottom: $toolbar-ios-padding-top;
/// @prop - Padding start of the toolbar
$toolbar-ios-padding-start: $toolbar-ios-padding-end !default;
$toolbar-ios-padding-start: $toolbar-ios-padding-end;
/// @prop - Font size of the toolbar button
/// The minimum and maximum font sizes for a toolbar button are
/// 100% and 135%, respectively, of their default font size
$toolbar-ios-button-font-size: dynamic-font-clamp(1, 17px, 1.24) !default;
$toolbar-ios-button-font-size: dynamic-font-clamp(1, 17px, 1.24);
/// @prop - Border radius of the toolbar button
$toolbar-ios-button-border-radius: 4px !default;
$toolbar-ios-button-border-radius: 4px;

2
core/src/components/toolbar/toolbar.md.vars.scss
View File

@ -16,4 +16,4 @@ $toolbar-order-md: (
);
/// @prop - Border radius of the toolbar button
$toolbar-md-button-border-radius: 2px !default;
$toolbar-md-button-border-radius: 2px;