javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(theming): remove Sass default flags (#29401)

Browse Source 
Issue number: N/A

---------

## What is the current behavior?
Currently, every Sass variable in Ionic has the `!default` flag added to
the end.

From the [Sass variables
documentation](https://sass-lang.com/documentation/variables/):

> Normally when you assign a value to a variable, if that variable
already had a value, its old value is overwritten. But if you’re writing
a Sass library, you might want to allow your users to configure your
library’s variables before you use them to generate CSS.
> 
> To make this possible, Sass provides the `!default` flag. This assigns
a value to a variable only if that variable isn’t defined or its value
is [null](https://sass-lang.com/documentation/values/null). Otherwise,
the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to
rebuild Ionic Framework using their own values. In the latest versions
of Ionic Framework, this is not possible.

## What is the new behavior?
Removes the `!default` flag from all Sass variables.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

-------

Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com>
This commit is contained in:
Liam DeBeasi
2024-04-25 15:59:10 -04:00
committed by GitHub
parent 0873dc2ffb
commit 6e8bf4914f
127 changed files with 1301 additions and 1301 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/src/components/tab-button/tab-button.ios.vars.scss
View File

@ -4,28 +4,28 @@
// --------------------------------------------------
/// @prop - Padding top on the tab button
$tab-button-ios-padding-top: 0 !default;
$tab-button-ios-padding-top: 0;
/// @prop - Padding end on the tab button
$tab-button-ios-padding-end: 2px !default;
$tab-button-ios-padding-end: 2px;
/// @prop - Padding bottom on the tab button
$tab-button-ios-padding-bottom: $tab-button-ios-padding-top !default;
$tab-button-ios-padding-bottom: $tab-button-ios-padding-top;
/// @prop - Padding start on the tab button
$tab-button-ios-padding-start: $tab-button-ios-padding-end !default;
$tab-button-ios-padding-start: $tab-button-ios-padding-end;
/// @prop - Max width of the tab button
$tab-button-ios-max-width: 240px !default;
$tab-button-ios-max-width: 240px;
/// @prop - Text color of the inactive tab button
$tab-button-ios-text-color: $tabbar-ios-color !default;
$tab-button-ios-text-color: $tabbar-ios-color;
/// @prop - Font size of the tab button text
$tab-button-ios-font-size: 10px !default;
$tab-button-ios-font-size: 10px;
/// @prop - Size of the tab button icon when there is a label
$tab-button-ios-icon-size: 24px !default;
$tab-button-ios-icon-size: 24px;
/// @prop - Size of the tab button icon when there is not a label
$tab-button-ios-icon-only-size: 30px !default;
$tab-button-ios-icon-only-size: 30px;

52
core/src/components/tab-button/tab-button.md.vars.scss
View File

@ -4,79 +4,79 @@
// --------------------------------------------------
/// @prop - Padding top on the tab button
$tab-button-md-padding-top: 0 !default;
$tab-button-md-padding-top: 0;
/// @prop - Padding end on the tab button
$tab-button-md-padding-end: 12px !default;
$tab-button-md-padding-end: 12px;
/// @prop - Padding bottom on the tab button
$tab-button-md-padding-bottom: 0 !default;
$tab-button-md-padding-bottom: 0;
/// @prop - Padding start on the tab button
$tab-button-md-padding-start: 12px !default;
$tab-button-md-padding-start: 12px;
/// @prop - Font size of the inactive tab button text
$tab-button-md-font-size: 12px !default;
$tab-button-md-font-size: 12px;
/// @prop - Letter spacing of the tab button
$tab-button-md-letter-spacing: .03em !default;
$tab-button-md-letter-spacing: .03em;
/// @prop - Font weight of the tab button text
$tab-button-md-font-weight: normal !default;
$tab-button-md-font-weight: normal;
/// @prop - Text color of the inactive tab button
$tab-button-md-text-color: $tabbar-md-color !default;
$tab-button-md-text-color: $tabbar-md-color;
/// @prop - Margin top on the tab button icon
$tab-button-md-icon-margin-top: 16px !default;
$tab-button-md-icon-margin-top: 16px;
/// @prop - Margin end on the tab button icon
$tab-button-md-icon-margin-end: 0 !default;
$tab-button-md-icon-margin-end: 0;
/// @prop - Margin bottom on the tab button icon
$tab-button-md-icon-margin-bottom: $tab-button-md-icon-margin-top !default;
$tab-button-md-icon-margin-bottom: $tab-button-md-icon-margin-top;
/// @prop - Margin start on the tab button icon
$tab-button-md-icon-margin-start: $tab-button-md-icon-margin-end !default;
$tab-button-md-icon-margin-start: $tab-button-md-icon-margin-end;
/// @prop - Margin top on the tab button text
$tab-button-md-text-margin-top: 2px !default;
$tab-button-md-text-margin-top: 2px;
/// @prop - Margin end on the tab button text
$tab-button-md-text-margin-end: 0 !default;
$tab-button-md-text-margin-end: 0;
/// @prop - Margin bottom on the tab button text
$tab-button-md-text-margin-bottom: $tab-button-md-text-margin-top !default;
$tab-button-md-text-margin-bottom: $tab-button-md-text-margin-top;
/// @prop - Margin start on the tab button text
$tab-button-md-text-margin-start: $tab-button-md-text-margin-end !default;
$tab-button-md-text-margin-start: $tab-button-md-text-margin-end;
/// @prop - Capitalization of the tab button text
$tab-button-md-text-capitalization: none !default;
$tab-button-md-text-capitalization: none;
/// @prop - Size of the tab button icon
$tab-button-md-icon-size: 22px !default;
$tab-button-md-icon-size: 22px;
/// @prop - Border radius on the tab button badge
$tab-button-md-badge-border-radius: 8px !default;
$tab-button-md-badge-border-radius: 8px;
/// @prop - Padding top on the tab button badge
$tab-button-md-badge-padding-top: 3px !default;
$tab-button-md-badge-padding-top: 3px;
/// @prop - Padding end on the tab button badge
$tab-button-md-badge-padding-end: 2px !default;
$tab-button-md-badge-padding-end: 2px;
/// @prop - Padding bottom on the tab button badge
$tab-button-md-badge-padding-bottom: 2px !default;
$tab-button-md-badge-padding-bottom: 2px;
/// @prop - Padding start on the tab button badge
$tab-button-md-badge-padding-start: 2px !default;
$tab-button-md-badge-padding-start: 2px;
/// @prop - Minimum width of the tab button badge
$tab-button-md-badge-min-width: 12px !default;
$tab-button-md-badge-min-width: 12px;
/// @prop - Font size of the tab button badge
$tab-button-md-badge-font-size: 8px !default;
$tab-button-md-badge-font-size: 8px;
/// @prop - Size of the empty tab button badge
$tab-button-md-badge-size-empty: 8px !default;
$tab-button-md-badge-size-empty: 8px;