javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(theming): remove Sass default flags (#29401)

Browse Source 
Issue number: N/A

---------

## What is the current behavior?
Currently, every Sass variable in Ionic has the `!default` flag added to
the end.

From the [Sass variables
documentation](https://sass-lang.com/documentation/variables/):

> Normally when you assign a value to a variable, if that variable
already had a value, its old value is overwritten. But if you’re writing
a Sass library, you might want to allow your users to configure your
library’s variables before you use them to generate CSS.
> 
> To make this possible, Sass provides the `!default` flag. This assigns
a value to a variable only if that variable isn’t defined or its value
is [null](https://sass-lang.com/documentation/values/null). Otherwise,
the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to
rebuild Ionic Framework using their own values. In the latest versions
of Ionic Framework, this is not possible.

## What is the new behavior?
Removes the `!default` flag from all Sass variables.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

-------

Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com>
This commit is contained in:
Liam DeBeasi
2024-04-25 15:59:10 -04:00
committed by GitHub
parent 0873dc2ffb
commit 6e8bf4914f
127 changed files with 1301 additions and 1301 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/components/infinite-scroll-content/infinite-scroll-content.ios.vars.scss
View File

@ -4,7 +4,7 @@
// --------------------------------------------------
/// @prop - Color of the infinite scroll loading indicator
$infinite-scroll-ios-loading-color: $text-color-step-400 !default;
$infinite-scroll-ios-loading-color: $text-color-step-400;
/// @prop - Color of the infinite scroll loading indicator text
$infinite-scroll-ios-loading-text-color: $infinite-scroll-ios-loading-color !default;
$infinite-scroll-ios-loading-text-color: $infinite-scroll-ios-loading-color;

4
core/src/components/infinite-scroll-content/infinite-scroll-content.md.vars.scss
View File

@ -4,7 +4,7 @@
// --------------------------------------------------
/// @prop - Color of the infinite scroll loading indicator
$infinite-scroll-md-loading-color: $text-color-step-400 !default;
$infinite-scroll-md-loading-color: $text-color-step-400;
/// @prop - Color of the infinite scroll loading indicator text
$infinite-scroll-md-loading-text-color: $infinite-scroll-md-loading-color !default;
$infinite-scroll-md-loading-text-color: $infinite-scroll-md-loading-color;

18
core/src/components/infinite-scroll-content/infinite-scroll-content.vars.scss
View File

@ -4,28 +4,28 @@
// --------------------------------------------------
/// @prop - Minimum height of the infinite scroll content
$infinite-scroll-content-min-height: 84px !default;
$infinite-scroll-content-min-height: 84px;
/// @prop - Margin top of the infinite scroll loading icon
$infinite-scroll-loading-margin-top: 0 !default;
$infinite-scroll-loading-margin-top: 0;
/// @prop - Margin end of the infinite scroll loading icon
$infinite-scroll-loading-margin-end: 0 !default;
$infinite-scroll-loading-margin-end: 0;
/// @prop - Margin bottom of the infinite scroll loading icon
$infinite-scroll-loading-margin-bottom: 32px !default;
$infinite-scroll-loading-margin-bottom: 32px;
/// @prop - Margin start of the infinite scroll loading icon
$infinite-scroll-loading-margin-start: $infinite-scroll-loading-margin-end !default;
$infinite-scroll-loading-margin-start: $infinite-scroll-loading-margin-end;
/// @prop - Margin top of the infinite scroll loading text
$infinite-scroll-loading-text-margin-top: 4px !default;
$infinite-scroll-loading-text-margin-top: 4px;
/// @prop - Margin end of the infinite scroll loading text
$infinite-scroll-loading-text-margin-end: 32px !default;
$infinite-scroll-loading-text-margin-end: 32px;
/// @prop - Margin bottom of the infinite scroll loading text
$infinite-scroll-loading-text-margin-bottom: 0 !default;
$infinite-scroll-loading-text-margin-bottom: 0;
/// @prop - Margin start of the infinite scroll loading text
$infinite-scroll-loading-text-margin-start: $infinite-scroll-loading-text-margin-end !default;
$infinite-scroll-loading-text-margin-start: $infinite-scroll-loading-text-margin-end;