javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 15:51:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(theming): remove Sass default flags (#29401)

Browse Source 
Issue number: N/A

---------

## What is the current behavior?
Currently, every Sass variable in Ionic has the `!default` flag added to
the end.

From the [Sass variables
documentation](https://sass-lang.com/documentation/variables/):

> Normally when you assign a value to a variable, if that variable
already had a value, its old value is overwritten. But if you’re writing
a Sass library, you might want to allow your users to configure your
library’s variables before you use them to generate CSS.
> 
> To make this possible, Sass provides the `!default` flag. This assigns
a value to a variable only if that variable isn’t defined or its value
is [null](https://sass-lang.com/documentation/values/null). Otherwise,
the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to
rebuild Ionic Framework using their own values. In the latest versions
of Ionic Framework, this is not possible.

## What is the new behavior?
Removes the `!default` flag from all Sass variables.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

-------

Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com>
This commit is contained in:
Liam DeBeasi
2024-04-25 15:59:10 -04:00
committed by GitHub
parent 0873dc2ffb
commit 6e8bf4914f
127 changed files with 1301 additions and 1301 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/components/checkbox/checkbox.ios.vars.scss
View File

@ -6,25 +6,25 @@
// --------------------------------------------------
/// @prop - Background color of the checkbox when off
$checkbox-ios-background-color-off: $item-ios-background !default;
$checkbox-ios-background-color-off: $item-ios-background;
/// @prop - Size of the checkbox icon
$checkbox-ios-icon-size: dynamic-font-max(22px, 2.538) !default;
$checkbox-ios-icon-size: dynamic-font-max(22px, 2.538);
/// @prop - Border color of the checkbox icon when off
$checkbox-ios-icon-border-color-off: rgba($text-color-rgb, 0.23) !default;
$checkbox-ios-icon-border-color-off: rgba($text-color-rgb, 0.23);
/// @prop - Border width of the checkbox icon
$checkbox-ios-icon-border-width: dynamic-font(2px) !default;
$checkbox-ios-icon-border-width: dynamic-font(2px);
/// @prop - Border style of the checkbox icon
$checkbox-ios-icon-border-style: solid !default;
$checkbox-ios-icon-border-style: solid;
/// @prop - Border radius of the checkbox icon
$checkbox-ios-icon-border-radius: 50% !default;
$checkbox-ios-icon-border-radius: 50%;
/// @prop - Opacity of the disabled checkbox
$checkbox-ios-disabled-opacity: $form-control-ios-disabled-opacity !default;
$checkbox-ios-disabled-opacity: $form-control-ios-disabled-opacity;
/// @prop - Checkmark width of the checkbox icon
$checkbox-ios-icon-checkmark-width: 1.5px !default;
$checkbox-ios-icon-checkmark-width: 1.5px;

18
core/src/components/checkbox/checkbox.md.vars.scss
View File

@ -5,30 +5,30 @@
// --------------------------------------------------
/// @prop - Opacity of the disabled checkbox label
$checkbox-md-disabled-opacity: $form-control-md-disabled-opacity !default;
$checkbox-md-disabled-opacity: $form-control-md-disabled-opacity;
/// @prop - Background color of the checkbox icon when off
$checkbox-md-icon-background-color-off: $item-md-background !default;
$checkbox-md-icon-background-color-off: $item-md-background;
/// @prop - Size of the checkbox icon
/// The icon size does not use dynamic font
/// because it does not scale in native.
$checkbox-md-icon-size: 18px !default;
$checkbox-md-icon-size: 18px;
/// @prop - Border width of the checkbox icon
$checkbox-md-icon-border-width: 2px !default;
$checkbox-md-icon-border-width: 2px;
/// @prop - Border style of the checkbox icon
$checkbox-md-icon-border-style: solid !default;
$checkbox-md-icon-border-style: solid;
/// @prop - Border color of the checkbox icon when off
$checkbox-md-icon-border-color-off: rgb($text-color-rgb, 0.60) !default;
$checkbox-md-icon-border-color-off: rgb($text-color-rgb, 0.60);
/// @prop - Transition duration of the checkbox
$checkbox-md-transition-duration: 180ms !default;
$checkbox-md-transition-duration: 180ms;
/// @prop - Transition easing of the checkbox
$checkbox-md-transition-easing: cubic-bezier(.4, 0, .2, 1) !default;
$checkbox-md-transition-easing: cubic-bezier(.4, 0, .2, 1);
/// @prop - Opacity of the disabled checkbox
/// This value is used because the checkbox color is set to
@ -37,4 +37,4 @@ $checkbox-md-transition-easing: cubic-bezier(.4, 0, .2, 1) !default;
/// opacity is applied on top of the transparent color so
/// this opacity gets us the equivalent of applying `0.38`
/// on top of an opaque checkbox `rgb(0, 0, 0, 1.0)`
$checkbox-md-icon-disabled-opacity: 0.63 !default;
$checkbox-md-icon-disabled-opacity: 0.63;

4
core/src/components/checkbox/checkbox.vars.scss
View File

@ -1,5 +1,5 @@
/// @prop - Top margin of checkbox's label when in an item
$checkbox-item-label-margin-top: 10px !default;
$checkbox-item-label-margin-top: 10px;
/// @prop - Bottom margin of checkbox's label when in an item
$checkbox-item-label-margin-bottom: 10px !default;
$checkbox-item-label-margin-bottom: 10px;