diff --git a/BREAKING.md b/BREAKING.md index 259c8c9820..2858e6d446 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -24,6 +24,7 @@ This is a comprehensive list of the breaking changes introduced in the major ver - [Nav](#version-8x-nav) - [Picker](#version-8x-picker) - [Progress bar](#version-8x-progress-bar) + - [Select](#version-8x-select) - [Textarea](#version-8x-textarea)

Browser and Platform Support

@@ -176,6 +177,10 @@ For more information on the dynamic font, refer to the [Dynamic Font Scaling doc For more information on styling toast buttons, refer to the [Toast Theming documentation](https://ionicframework.com/docs/api/toast#theming). +

Select

+ +- The `legacy` property and support for the legacy syntax, which involved placing an `ion-select` inside of an `ion-item` with an `ion-label`, have been removed. For more information on migrating from the legacy select syntax, refer to the [Select documentation](https://ionicframework.com/docs/api/select#migrating-from-legacy-select-syntax). +

Textarea

- The `legacy` property and support for the legacy syntax, which involved placing an `ion-textarea` inside of an `ion-item` with an `ion-label`, have been removed. For more information on migrating from the legacy textarea syntax, refer to the [Textarea documentation](https://ionicframework.com/docs/api/textarea#migrating-from-legacy-textarea-syntax). diff --git a/core/api.txt b/core/api.txt index 8b601ae780..1241a58e60 100644 --- a/core/api.txt +++ b/core/api.txt @@ -1275,7 +1275,6 @@ ion-select,prop,interfaceOptions,any,{},false,false ion-select,prop,justify,"end" | "space-between" | "start",'space-between',false,false ion-select,prop,label,string | undefined,undefined,false,false ion-select,prop,labelPlacement,"end" | "fixed" | "floating" | "stacked" | "start" | undefined,'start',false,false -ion-select,prop,legacy,boolean | undefined,undefined,false,false ion-select,prop,mode,"ios" | "md",undefined,false,false ion-select,prop,multiple,boolean,false,false,false ion-select,prop,name,string,this.inputId,false,false diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 4e4795c1e5..68efdd59e7 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -2739,10 +2739,6 @@ export namespace Components { * Where to place the label relative to the select. `"start"`: The label will appear to the left of the select in LTR and to the right in RTL. `"end"`: The label will appear to the right of the select in LTR and to the left in RTL. `"floating"`: The label will appear smaller and above the select when the select is focused or it has a value. Otherwise it will appear on top of the select. `"stacked"`: The label will appear smaller and above the select regardless even when the select is blurred or has no value. `"fixed"`: The label has the same behavior as `"start"` except it also has a fixed width. Long text will be truncated with ellipses ("..."). When using `"floating"` or `"stacked"` we recommend initializing the select with either a `value` or a `placeholder`. */ "labelPlacement"?: 'start' | 'end' | 'floating' | 'stacked' | 'fixed'; - /** - * Set the `legacy` property to `true` to forcibly use the legacy form control markup. Ionic will only opt components in to the modern form markup when they are using either the `aria-label` attribute or the `label` property. As a result, the `legacy` property should only be used as an escape hatch when you want to avoid this automatic opt-in behavior. Note that this property will be removed in an upcoming major release of Ionic, and all form components will be opted-in to using the modern form markup. - */ - "legacy"?: boolean; /** * The mode determines which platform styles to use. */ @@ -7498,10 +7494,6 @@ declare namespace LocalJSX { * Where to place the label relative to the select. `"start"`: The label will appear to the left of the select in LTR and to the right in RTL. `"end"`: The label will appear to the right of the select in LTR and to the left in RTL. `"floating"`: The label will appear smaller and above the select when the select is focused or it has a value. Otherwise it will appear on top of the select. `"stacked"`: The label will appear smaller and above the select regardless even when the select is blurred or has no value. `"fixed"`: The label has the same behavior as `"start"` except it also has a fixed width. Long text will be truncated with ellipses ("..."). When using `"floating"` or `"stacked"` we recommend initializing the select with either a `value` or a `placeholder`. */ "labelPlacement"?: 'start' | 'end' | 'floating' | 'stacked' | 'fixed'; - /** - * Set the `legacy` property to `true` to forcibly use the legacy form control markup. Ionic will only opt components in to the modern form markup when they are using either the `aria-label` attribute or the `label` property. As a result, the `legacy` property should only be used as an escape hatch when you want to avoid this automatic opt-in behavior. Note that this property will be removed in an upcoming major release of Ionic, and all form components will be opted-in to using the modern form markup. - */ - "legacy"?: boolean; /** * The mode determines which platform styles to use. */ diff --git a/core/src/components/item/item.ios.scss b/core/src/components/item/item.ios.scss index 9b107457e9..d27d8f6a9a 100644 --- a/core/src/components/item/item.ios.scss +++ b/core/src/components/item/item.ios.scss @@ -213,18 +213,9 @@ --min-height: 68px; } -:host(.item-label-stacked) ::slotted(ion-select.legacy-select), -:host(.item-label-floating) ::slotted(ion-select.legacy-select) { - --padding-top: 8px; - --padding-bottom: 8px; - --padding-start: 0px; -} - - // iOS Fixed Labels // -------------------------------------------------- -:host(.item-label-fixed) ::slotted(ion-select.legacy-select), :host(.item-label-fixed) ::slotted(ion-datetime) { --padding-start: 0; } diff --git a/core/src/components/item/item.md.scss b/core/src/components/item/item.md.scss index 5075928031..1444bb6ded 100644 --- a/core/src/components/item/item.md.scss +++ b/core/src/components/item/item.md.scss @@ -319,7 +319,6 @@ // Material Design Fixed Labels // -------------------------------------------------- -:host(.item-label-fixed) ::slotted(ion-select.legacy-select), :host(.item-label-fixed) ::slotted(ion-datetime) { --padding-start: 8px; } @@ -365,13 +364,6 @@ --min-height: 55px; } -:host(.item-label-stacked) ::slotted(ion-select.legacy-select), -:host(.item-label-floating) ::slotted(ion-select.legacy-select) { - --padding-top: 8px; - --padding-bottom: 8px; - --padding-start: 0; -} - :host(.ion-focused:not(.ion-color)) ::slotted(.label-stacked), :host(.ion-focused:not(.ion-color)) ::slotted(.label-floating), :host(.item-has-focus:not(.ion-color)) ::slotted(.label-stacked), diff --git a/core/src/components/item/item.scss b/core/src/components/item/item.scss index aa52b7b953..311ea1c020 100644 --- a/core/src/components/item/item.scss +++ b/core/src/components/item/item.scss @@ -535,29 +535,6 @@ button, a { display: block; } -// Item Select -// -------------------------------------------------- - -:host(:not(.item-label)) ::slotted(ion-select.legacy-select) { - --padding-start: 0; - - max-width: none; -} - -:host(.item-label-stacked) ::slotted(ion-select.legacy-select), -:host(.item-label-floating) ::slotted(ion-select.legacy-select) { - --padding-top: 8px; - --padding-bottom: 8px; - --padding-start: 0; - - align-self: stretch; - - width: 100%; - - max-width: 100%; -} - - // Item Datetime // -------------------------------------------------- @@ -580,8 +557,7 @@ button, a { :host(.item-multiple-inputs) ::slotted(ion-checkbox), :host(.item-multiple-inputs) ::slotted(ion-datetime), -:host(.item-multiple-inputs) ::slotted(ion-radio), -:host(.item-multiple-inputs) ::slotted(ion-select.legacy-select) { +:host(.item-multiple-inputs) ::slotted(ion-radio) { position: relative; } diff --git a/core/src/components/item/test/disabled/index.html b/core/src/components/item/test/disabled/index.html index ce5522bfde..6cb3b2ae66 100644 --- a/core/src/components/item/test/disabled/index.html +++ b/core/src/components/item/test/disabled/index.html @@ -39,18 +39,6 @@ Disabled Item Anchor - - - No Game Console - NES - Nintendo64 - PlayStation - Sega Genesis - Sega Saturn - SNES - - - Disabled Toggle @@ -89,25 +77,6 @@ Checkbox + Radio - - Disabled Selects - - January - February - March - - - 1990 - 1991 - 1992 - 1993 - 1994 - 1995 - 1996 - 1997 - - - Checkbox + Range diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png index 78d48c63e6..272b191e44 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png index bbd0c6d8df..ae86aebc14 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png index 40d55dbb93..5bb51b0426 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png index 1005e71fb2..844700c7e0 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png index 063108c89e..7fde6e073d 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png index 3b8cc1a766..0ca0845639 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/legacy/alignment/index.html b/core/src/components/item/test/legacy/alignment/index.html deleted file mode 100644 index 75a571faa5..0000000000 --- a/core/src/components/item/test/legacy/alignment/index.html +++ /dev/null @@ -1,104 +0,0 @@ - - - - - Item - Alignment - - - - - - - - - - - - - Item - Alignment - - - - - - Leading Icons - - - - Madison, WI - Atlanta, GA - - - - - - Default Labels - - Destination - - Madison, WI - Atlanta, GA - - - - - - Fixed Labels - - Destination - - Madison, WI - Atlanta, GA - - - - - - Floating Labels - - Destination - - Madison, WI - Atlanta, GA - - - - - - Stacked Labels - - Destination - - Madison, WI - Atlanta, GA - - - - - - End Labels - - Destination - - Madison, WI - Atlanta, GA - - - - - - - - - diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts b/core/src/components/item/test/legacy/alignment/item.e2e.ts deleted file mode 100644 index 7f4ff865bd..0000000000 --- a/core/src/components/item/test/legacy/alignment/item.e2e.ts +++ /dev/null @@ -1,14 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs().forEach(({ title, screenshot, config }) => { - test.describe(title('item: alignment'), () => { - test('should not have visual regressions', async ({ page }) => { - await page.goto(`/src/components/item/test/legacy/alignment`, config); - - await page.setIonViewport(); - - await expect(page).toHaveScreenshot(screenshot(`item-alignment-diff`)); - }); - }); -}); diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 6dbe47e837..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 5f5294a0f8..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index a08b2234c1..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 6afcd46483..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 7774321d30..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 1003248d79..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index d78b464c6a..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 5e847ab303..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 3380dce8a8..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 91c083c070..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 48cd62017d..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 672dbdeb39..0000000000 Binary files a/core/src/components/item/test/legacy/alignment/item.e2e.ts-snapshots/item-alignment-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/item/test/legacy/disabled/index.html b/core/src/components/item/test/legacy/disabled/index.html index 27075ae917..b64f3647d2 100644 --- a/core/src/components/item/test/legacy/disabled/index.html +++ b/core/src/components/item/test/legacy/disabled/index.html @@ -39,19 +39,6 @@ Disabled Item Anchor - - Disabled Select - - No Game Console - NES - Nintendo64 - PlayStation - Sega Genesis - Sega Saturn - SNES - - - Disabled Toggle @@ -92,25 +79,6 @@ Checkbox + Radio - - Disabled Selects - - January - February - March - - - 1990 - 1991 - 1992 - 1993 - 1994 - 1995 - 1996 - 1997 - - - Checkbox + Range diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png index fabac26b76..c459077b4a 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png index 8f0ab07dac..b645dcbc40 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png index 1e2c5269f9..4f0acae9c1 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png index 5c7a8a4638..41274b7653 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Firefox-linux.png index 960998eea2..c0fcce36c4 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Safari-linux.png index fffce9439a..f2cadffcb4 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png index 433d6f167b..2fc3b4086c 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png index c42a8a6752..bac3bf2eeb 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png index 46735a2343..82aa463e7f 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png index c07accdb6e..26dac515a5 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Firefox-linux.png index 4b21ee3ef6..4cd2759ce7 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Safari-linux.png index 9882661f27..dce040be17 100644 Binary files a/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Safari-linux.png and b/core/src/components/item/test/legacy/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/select/select.ios.scss b/core/src/components/select/select.ios.scss index 76c79ce72e..2e24dc9b83 100644 --- a/core/src/components/select/select.ios.scss +++ b/core/src/components/select/select.ios.scss @@ -4,14 +4,6 @@ // iOS Select // -------------------------------------------------- -// TODO FW-3194 - Remove this -:host(.legacy-select) { - --padding-top: #{$select-ios-padding-top}; - --padding-end: #{$select-ios-padding-end}; - --padding-bottom: #{$select-ios-padding-bottom}; - --padding-start: #{$select-ios-padding-start}; -} - .select-icon { width: $select-ios-icon-size; height: $select-ios-icon-size; diff --git a/core/src/components/select/select.ios.vars.scss b/core/src/components/select/select.ios.vars.scss index cb50b10d15..57677a8438 100644 --- a/core/src/components/select/select.ios.vars.scss +++ b/core/src/components/select/select.ios.vars.scss @@ -4,18 +4,6 @@ // iOS Select // -------------------------------------------------- -/// @prop - Padding top of the select -$select-ios-padding-top: $item-ios-padding-top !default; - -/// @prop - Padding end of the select -$select-ios-padding-end: ($item-ios-padding-end * 0.5) !default; - -/// @prop - Padding bottom of the select -$select-ios-padding-bottom: $item-ios-padding-bottom !default; - -/// @prop - Padding start of the select -$select-ios-padding-start: $item-ios-padding-start !default; - /// @prop - Size of the select icon $select-ios-icon-size: dynamic-font(18px) !default; diff --git a/core/src/components/select/select.md.scss b/core/src/components/select/select.md.scss index 005c54e7f7..cac2cd3e93 100644 --- a/core/src/components/select/select.md.scss +++ b/core/src/components/select/select.md.scss @@ -11,14 +11,6 @@ --border-color: #{$item-md-border-color}; } -// TODO FW-3194 - Remove this -:host(.legacy-select) { - --padding-top: #{$select-md-padding-top}; - --padding-end: #{$select-md-padding-end}; - --padding-bottom: #{$select-md-padding-bottom}; - --padding-start: #{$select-md-padding-start}; -} - .select-icon { width: $select-md-icon-size; @@ -89,7 +81,7 @@ * when the select is activated. * This should only happen on MD. */ -:host(.select-expanded:not(.legacy-select):not(.has-expanded-icon)) .select-icon { +:host(.select-expanded:not(.has-expanded-icon)) .select-icon { @include transform(rotate(180deg)); } diff --git a/core/src/components/select/select.md.vars.scss b/core/src/components/select/select.md.vars.scss index db460f063f..a6125e618d 100644 --- a/core/src/components/select/select.md.vars.scss +++ b/core/src/components/select/select.md.vars.scss @@ -4,18 +4,6 @@ // Material Design Select // -------------------------------------------------- -/// @prop - Padding top of the select -$select-md-padding-top: $item-md-padding-top !default; - -/// @prop - Padding end of the select -$select-md-padding-end: 0 !default; - -/// @prop - Padding bottom of the select -$select-md-padding-bottom: $select-md-padding-top !default; - -/// @prop - Padding start of the select -$select-md-padding-start: $item-md-padding-start !default; - /// @prop - Size of the select icon $select-md-icon-size: dynamic-font(13px) !default; /// @prop - The amount of whitespace to display on either side of the floating label diff --git a/core/src/components/select/select.scss b/core/src/components/select/select.scss index 965f0a4320..877c2ab92c 100644 --- a/core/src/components/select/select.scss +++ b/core/src/components/select/select.scss @@ -48,6 +48,9 @@ display: block; position: relative; + width: 100%; + min-height: 44px; + font-family: $font-family-base; white-space: nowrap; @@ -56,12 +59,6 @@ z-index: $z-index-item-input; } -// TODO FW-3194 - Move this to host -:host(:not(.legacy-select)) { - width: 100%; - min-height: 44px; -} - /** * Since the label sits on top of the element, * the component needs to be taller otherwise the @@ -76,36 +73,16 @@ --highlight-color-focused: #{current-color(base)}; } -// TODO FW-3194 - Remove this -:host(.legacy-select) { - @include padding(var(--padding-top), var(--padding-end), var(--padding-bottom), var(--padding-start)); - - display: flex; - - align-items: center; - - overflow: hidden; -} - // Select Used in ion-item // -------------------------------------------------- -// TODO FW-3194 - Remove the :not(.legacy-select) piece -// // The flex property is required here in order to allow // the select to shrink inside of an item otherwise it // always wraps to the next line even when it can shrink -:host(.in-item:not(.legacy-select)) { +:host(.in-item) { flex: 1 1 0; } -// TODO FW-3194 - Remove this -:host(.in-item.legacy-select) { - position: static; - - max-width: 45%; -} - :host(.select-disabled) { pointer-events: none; } @@ -114,15 +91,14 @@ border: 2px solid #5e9ed6; } -// TODO FW-3194 - Remove :not(.legacy-select) piece /** * Select can be slotted * in components such as item and * toolbar which is why we do not * limit the below behavior to just ion-item. */ -:host([slot="start"]:not(.legacy-select)), -:host([slot="end"]:not(.legacy-select)) { +:host([slot="start"]), +:host([slot="end"]) { width: auto; } @@ -132,17 +108,6 @@ opacity: var(--placeholder-opacity); } -// TODO FW-3194 - Remove this -:host(.legacy-select) label { - @include input-cover(); - - display: flex; - - align-items: center; - - opacity: 0; -} - button { @include visually-hidden(); } diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx index 9fe26349bb..3a7a04f5f2 100644 --- a/core/src/components/select/select.tsx +++ b/core/src/components/select/select.tsx @@ -1,10 +1,9 @@ import type { ComponentInterface, EventEmitter } from '@stencil/core'; import { Component, Element, Event, Host, Method, Prop, State, Watch, h, forceUpdate } from '@stencil/core'; -import type { LegacyFormController, NotchController } from '@utils/forms'; -import { compareOptions, createLegacyFormController, createNotchController, isOptionSelected } from '@utils/forms'; -import { findItemLabel, focusElement, getAriaLabel, renderHiddenInput, inheritAttributes } from '@utils/helpers'; +import type { NotchController } from '@utils/forms'; +import { compareOptions, createNotchController, isOptionSelected } from '@utils/forms'; +import { focusElement, getAriaLabel, renderHiddenInput, inheritAttributes } from '@utils/helpers'; import type { Attributes } from '@utils/helpers'; -import { printIonWarning } from '@utils/logging'; import { actionSheetController, alertController, popoverController } from '@utils/overlays'; import type { OverlaySelect } from '@utils/overlays-interface'; import { isRTL } from '@utils/rtl'; @@ -55,16 +54,12 @@ export class Select implements ComponentInterface { private overlay?: OverlaySelect; private focusEl?: HTMLButtonElement; private mutationO?: MutationObserver; - private legacyFormController!: LegacyFormController; private inheritedAttributes: Attributes = {}; private nativeWrapperEl: HTMLElement | undefined; private notchSpacerEl: HTMLElement | undefined; private notchController?: NotchController; - // This flag ensures we log the deprecation warning at most once. - private hasLoggedDeprecationWarning = false; - @Element() el!: HTMLIonSelectElement; @State() isExpanded = false; @@ -152,17 +147,6 @@ export class Select implements ComponentInterface { */ @Prop() labelPlacement?: 'start' | 'end' | 'floating' | 'stacked' | 'fixed' = 'start'; - /** - * Set the `legacy` property to `true` to forcibly use the legacy form control markup. - * Ionic will only opt components in to the modern form markup when they are - * using either the `aria-label` attribute or the `label` property. As a result, - * the `legacy` property should only be used as an escape hatch when you want to - * avoid this automatic opt-in behavior. - * Note that this property will be removed in an upcoming major release - * of Ionic, and all form components will be opted-in to using the modern form markup. - */ - @Prop() legacy?: boolean; - /** * If `true`, the select can accept multiple values. */ @@ -262,7 +246,6 @@ export class Select implements ComponentInterface { async connectedCallback() { const { el } = this; - this.legacyFormController = createLegacyFormController(el); this.notchController = createNotchController( el, () => this.notchSpacerEl, @@ -515,44 +498,27 @@ export class Select implements ComponentInterface { let event: Event | CustomEvent = ev; let size = 'auto'; - if (this.legacyFormController.hasLegacyControl()) { - const item = this.el.closest('ion-item'); + const hasFloatingOrStackedLabel = labelPlacement === 'floating' || labelPlacement === 'stacked'; + /** + * The popover should take up the full width + * when using a fill in MD mode or if the + * label is floating/stacked. + */ + if (hasFloatingOrStackedLabel || (mode === 'md' && fill !== undefined)) { + size = 'cover'; - // If the select is inside of an item containing a floating - // or stacked label then the popover should take up the - // full width of the item when it presents - if (item && (item.classList.contains('item-label-floating') || item.classList.contains('item-label-stacked'))) { - event = { - ...ev, - detail: { - ionShadowTarget: item, - }, - }; - size = 'cover'; - } - } else { - const hasFloatingOrStackedLabel = labelPlacement === 'floating' || labelPlacement === 'stacked'; /** - * The popover should take up the full width - * when using a fill in MD mode or if the - * label is floating/stacked. + * Otherwise the popover + * should be positioned relative + * to the native element. */ - if (hasFloatingOrStackedLabel || (mode === 'md' && fill !== undefined)) { - size = 'cover'; - - /** - * Otherwise the popover - * should be positioned relative - * to the native element. - */ - } else { - event = { - ...ev, - detail: { - ionShadowTarget: this.nativeWrapperEl, - }, - }; - } + } else { + event = { + ...ev, + detail: { + ionShadowTarget: this.nativeWrapperEl, + }, + }; } const popoverOpts: PopoverOptions = { @@ -618,23 +584,6 @@ export class Select implements ComponentInterface { } private async openAlert() { - /** - * TODO FW-3194 - * Remove legacyFormController logic. - * Remove label and labelText vars - * Pass `this.labelText` instead of `labelText` - * when setting the header. - */ - let label: HTMLElement | null; - let labelText: string | null | undefined; - - if (this.legacyFormController.hasLegacyControl()) { - label = this.getLabel(); - labelText = label ? label.textContent : null; - } else { - labelText = this.labelText; - } - const interfaceOptions = this.interfaceOptions; const inputType = this.multiple ? 'checkbox' : 'radio'; const mode = getIonMode(this); @@ -643,7 +592,7 @@ export class Select implements ComponentInterface { mode, ...interfaceOptions, - header: interfaceOptions.header ? interfaceOptions.header : labelText, + header: interfaceOptions.header ? interfaceOptions.header : this.labelText, inputs: this.createAlertInputs(this.childOpts, inputType, this.value), buttons: [ { @@ -692,11 +641,6 @@ export class Select implements ComponentInterface { return this.overlay.dismiss(); } - // TODO FW-3194 Remove this - private getLabel() { - return findItemLabel(this.el); - } - private hasValue(): boolean { return this.getText() !== ''; } @@ -745,21 +689,11 @@ export class Select implements ComponentInterface { private emitStyle() { const { disabled } = this; + const style: StyleEventDetail = { 'interactive-disabled': disabled, }; - if (this.legacyFormController.hasLegacyControl()) { - style['interactive'] = true; - style['select'] = true; - style['select-disabled'] = disabled; - style['has-placeholder'] = this.placeholder !== undefined; - style['has-value'] = this.hasValue(); - style['has-focus'] = this.isExpanded; - // TODO(FW-3194): remove this - style['legacy'] = !!this.legacy; - } - this.ionStyle.emit(style); } @@ -889,157 +823,6 @@ export class Select implements ComponentInterface { return this.renderLabel(); } - private renderSelect() { - const { disabled, el, isExpanded, expandedIcon, labelPlacement, justify, placeholder, fill, shape, name, value } = - this; - const mode = getIonMode(this); - const hasFloatingOrStackedLabel = labelPlacement === 'floating' || labelPlacement === 'stacked'; - const justifyEnabled = !hasFloatingOrStackedLabel; - const rtl = isRTL(el) ? 'rtl' : 'ltr'; - const inItem = hostContext('ion-item', this.el); - const shouldRenderHighlight = mode === 'md' && fill !== 'outline' && !inItem; - - const hasValue = this.hasValue(); - const hasStartEndSlots = el.querySelector('[slot="start"], [slot="end"]') !== null; - - renderHiddenInput(true, el, name, parseValue(value), disabled); - - /** - * If the label is stacked, it should always sit above the select. - * For floating labels, the label should move above the select if - * the select has a value, is open, or has anything in either - * the start or end slot. - * - * If there is content in the start slot, the label would overlap - * it if not forced to float. This is also applied to the end slot - * because with the default or solid fills, the select is not - * vertically centered in the container, but the label is. This - * causes the slots and label to appear vertically offset from each - * other when the label isn't floating above the input. This doesn't - * apply to the outline fill, but this was not accounted for to keep - * things consistent. - * - * TODO(FW-5592): Remove hasStartEndSlots condition - */ - const labelShouldFloat = - labelPlacement === 'stacked' || (labelPlacement === 'floating' && (hasValue || isExpanded || hasStartEndSlots)); - - return ( - - - - ); - } - - // TODO FW-3194 - Remove this - private renderLegacySelect() { - if (!this.hasLoggedDeprecationWarning) { - printIonWarning( - `ion-select now requires providing a label with either the "label" property or the "aria-label" attribute. To migrate, remove any usage of "ion-label" and pass the label text to either the "label" property or the "aria-label" attribute. - -Example: ... -Example with aria-label: ... - -Developers can use the "legacy" property to continue using the legacy form markup. This property will be removed in an upcoming major release of Ionic where this form control will use the modern form markup.`, - this.el - ); - - if (this.legacy) { - printIonWarning( - `ion-select is being used with the "legacy" property enabled which will forcibly enable the legacy form markup. This property will be removed in an upcoming major release of Ionic where this form control will use the modern form markup. - Developers can dismiss this warning by removing their usage of the "legacy" property and using the new select syntax.`, - this.el - ); - } - this.hasLoggedDeprecationWarning = true; - } - - const { disabled, el, inputId, isExpanded, expandedIcon, name, placeholder, value } = this; - const mode = getIonMode(this); - const { labelText, labelId } = getAriaLabel(el, inputId); - - renderHiddenInput(true, el, name, parseValue(value), disabled); - - const displayValue = this.getText(); - - let selectText = displayValue; - if (selectText === '' && placeholder !== undefined) { - selectText = placeholder; - } - - // If there is a label then we need to concatenate it with the - // current value (or placeholder) and a comma so it separates - // nicely when the screen reader announces it, otherwise just - // announce the value / placeholder - const displayLabel = - labelText !== undefined ? (selectText !== '' ? `${selectText}, ${labelText}` : labelText) : selectText; - - return ( - - {this.renderSelectText()} - {this.renderSelectIcon()} - - {this.renderListbox()} - - ); - } - /** * Renders either the placeholder * or the selected values based on @@ -1138,9 +921,86 @@ Developers can use the "legacy" property to continue using the legacy form marku } render() { - const { legacyFormController } = this; + const { disabled, el, isExpanded, expandedIcon, labelPlacement, justify, placeholder, fill, shape, name, value } = + this; + const mode = getIonMode(this); + const hasFloatingOrStackedLabel = labelPlacement === 'floating' || labelPlacement === 'stacked'; + const justifyEnabled = !hasFloatingOrStackedLabel; + const rtl = isRTL(el) ? 'rtl' : 'ltr'; + const inItem = hostContext('ion-item', this.el); + const shouldRenderHighlight = mode === 'md' && fill !== 'outline' && !inItem; - return legacyFormController.hasLegacyControl() ? this.renderLegacySelect() : this.renderSelect(); + const hasValue = this.hasValue(); + const hasStartEndSlots = el.querySelector('[slot="start"], [slot="end"]') !== null; + + renderHiddenInput(true, el, name, parseValue(value), disabled); + + /** + * If the label is stacked, it should always sit above the select. + * For floating labels, the label should move above the select if + * the select has a value, is open, or has anything in either + * the start or end slot. + * + * If there is content in the start slot, the label would overlap + * it if not forced to float. This is also applied to the end slot + * because with the default or solid fills, the select is not + * vertically centered in the container, but the label is. This + * causes the slots and label to appear vertically offset from each + * other when the label isn't floating above the input. This doesn't + * apply to the outline fill, but this was not accounted for to keep + * things consistent. + * + * TODO(FW-5592): Remove hasStartEndSlots condition + */ + const labelShouldFloat = + labelPlacement === 'stacked' || (labelPlacement === 'floating' && (hasValue || isExpanded || hasStartEndSlots)); + + return ( + + + + ); } } diff --git a/core/src/components/select/test/legacy/a11y/index.html b/core/src/components/select/test/legacy/a11y/index.html deleted file mode 100644 index b7e6cab6b4..0000000000 --- a/core/src/components/select/test/legacy/a11y/index.html +++ /dev/null @@ -1,163 +0,0 @@ - - - - - Select - a11y - - - - - - - - - - - - - Select - a11y - - - - - - - Native Select - - -
- - - -
- - - - - Custom Label Ionic Select - - - - Favorite Pet - - - Dog - Cat - Hamster - Parrot - Spider - Goldfish - - - - - Favorite Pet - - - Dog - Cat - Hamster - Parrot - Spider - Goldfish - - - - - Favorite Pet - - - Dog - Cat - Hamster - Parrot - Spider - Goldfish - - - - - - - Alert Ionic Select - - - - - - - Dog - Cat - Hamster - Parrot - Spider - Goldfish - - - - - - - Popover Ionic Select - - - - Favorite Pet - - - Dog - Cat - Hamster - Parrot - Spider - Goldfish - - - - - - - Action Sheet Ionic Select - - - - Favorite Pet - - - Dog - Cat - Hamster - Parrot - Spider - Goldfish - - - - - - - - - - - diff --git a/core/src/components/select/test/legacy/async/index.html b/core/src/components/select/test/legacy/async/index.html deleted file mode 100644 index 86776eedf5..0000000000 --- a/core/src/components/select/test/legacy/async/index.html +++ /dev/null @@ -1,53 +0,0 @@ - - - - - Select - Async - - - - - - - - - - - - - - - Label w/o Placeholder - - - - - Label with Placeholder - - - - - - diff --git a/core/src/components/select/test/legacy/async/select.e2e.ts b/core/src/components/select/test/legacy/async/select.e2e.ts deleted file mode 100644 index df22990e55..0000000000 --- a/core/src/components/select/test/legacy/async/select.e2e.ts +++ /dev/null @@ -1,20 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -/** - * This is checking internal logic. RTL tests are not needed - */ -configs({ directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe.skip(title('select: async'), () => { - test('should correctly set the value after a delay', async ({ page }) => { - await page.goto(`/src/components/select/test/legacy/async`, config); - const selectValueSet = await page.spyOnEvent('selectValueSet'); - - const select = page.locator('#default'); - - await selectValueSet.next(); - - await expect(select).toHaveJSProperty('value', 'bird'); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/basic/index.html b/core/src/components/select/test/legacy/basic/index.html deleted file mode 100644 index 54565090c7..0000000000 --- a/core/src/components/select/test/legacy/basic/index.html +++ /dev/null @@ -1,421 +0,0 @@ - - - - - Select - Basic - - - - - - - - - - - - - Select - Basic - - - - - - - Single Value Select - - - - Gender - - Female - Male - - - - - Hair Color - - Brown - Blonde - Black - Red - - - - - Skittles - - Red - Purple - Yellow - Orange - Green - - - - - - - Object Values with trackBy - - - - Users - - - - - - - Select - Custom Interface Options - - - - Alert - - Bacon - Black Olives - Extra Cheese - Green Peppers - Mushrooms - Onions - Pepperoni - Pineapple - Sausage - Spinach - - - - - Popover - - Brown - Blonde - Black - Red - - - - - Action Sheet - - Red - Purple - Yellow - Orange - Green - - - - - - - Popover Interface Select - - - - Gender - - Female - Male - - - - - Favorite food - - Steak - Pizza - Tacos - - - - - Date - - January - February - March - April - May - June - July - August - September - October - November - December - - - 1989 - 1990 - 1991 - 1992 - 1993 - 1994 - 1995 - 1996 - 1997 - 1998 - 1999 - - - - - Numbers - - 0 - 1 - 2 - 3 - 4 - 5 - - - - - - - Action Sheet Interface Select - - - - Mute Notifications - - For 15 Minutes - For 1 Hour - For 24 Hours - Until I turn it back on - - - - - Rating - - 1 Star - 2 Stars - 3 Stars - 4 Stars - 5 Stars - - - - - - - Multiple Value Select - - - - Toppings - - Bacon - Black Olives - Extra Cheese - Green Peppers - Mushrooms - Onions - Pepperoni - Pineapple - Sausage - Spinach - - - - - Pets - - Bird - Cat - Dog - Honey Badger - - - - - Numbers - - 0 - 1 - 2 - 3 - 4 - 5 - - - - - Toppings - - Extra cheese - Mushroom - Onion - Pepperoni - Sausage - - - - - Disabled - - Selected Text - - - - - Stacked - - Default - Other - N/A - - - - - Stacked: selected - - Default - Other - N/A - - - - - Floating - - Default - Other - N/A - - - - - Floating: selected - - Default - Other - N/A - - - - -
- Toggle Disabled -
- - - - - - - - diff --git a/core/src/components/select/test/legacy/basic/select.e2e.ts b/core/src/components/select/test/legacy/basic/select.e2e.ts deleted file mode 100644 index 9577d32dda..0000000000 --- a/core/src/components/select/test/legacy/basic/select.e2e.ts +++ /dev/null @@ -1,196 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs({ directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe(title('select: basic'), () => { - test.beforeEach(async ({ page }) => { - await page.goto('/src/components/select/test/legacy/basic', config); - }); - test.describe('select: alert', () => { - test('it should open an alert select', async ({ page }) => { - const ionAlertDidPresent = await page.spyOnEvent('ionAlertDidPresent'); - - await page.click('#customAlertSelect'); - - await ionAlertDidPresent.next(); - - await expect(page.locator('ion-alert')).toBeVisible(); - }); - }); - - test.describe('select: action sheet', () => { - test('it should open an action sheet select', async ({ page }) => { - const ionActionSheetDidPresent = await page.spyOnEvent('ionActionSheetDidPresent'); - - await page.click('#customActionSheetSelect'); - - await ionActionSheetDidPresent.next(); - - await expect(page.locator('ion-action-sheet')).toBeVisible(); - }); - }); - - test.describe('select: popover', () => { - test('it should open a popover select', async ({ page, browserName, skip }) => { - // TODO (FW-2979) - skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.'); - - const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent'); - - await page.click('#customPopoverSelect'); - - await ionPopoverDidPresent.next(); - - const popover = page.locator('ion-popover'); - - // TODO(FW-1436) - if (browserName !== 'firefox') { - // select has no value, so first option should be focused by default - const popoverOption1 = await popover.locator('.select-interface-option:first-of-type ion-radio'); - await expect(popoverOption1).toBeFocused(); - } - - await expect(popover).toBeVisible(); - }); - }); - }); -}); - -configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe(title('select: multiple selects'), () => { - test('should not open multiple alert windows when clicked multiple times', async ({ page }) => { - test.info().annotations.push({ - type: 'issue', - description: 'https://github.com/ionic-team/ionic-framework/issues/25126', - }); - - await page.goto('/src/components/select/test/legacy/basic', config); - - const select = page.locator('#gender'); - - await select.evaluate((el: HTMLSelectElement) => { - /* - * Playwright's click() method attempts to scroll to the handle - * to perform the action. That is problematic when the overlay - * is already visible. We manually click() the element instead - * to avoid flaky tests. - */ - el.click(); - el.click(); - el.click(); - }); - - const alerts = await page.$$('ion-alert'); - - expect(alerts.length).toBe(1); - }); - }); -}); - -/** - * ionChange has a consistent behavior across modes - */ -configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe(title('select: ionChange'), () => { - test('should fire ionChange when confirming a value from an alert', async ({ page }) => { - await page.setContent( - ` - - Apple - Banana - - `, - config - ); - - const ionAlertDidPresent = await page.spyOnEvent('ionAlertDidPresent'); - const ionChange = await page.spyOnEvent('ionChange'); - const select = page.locator('ion-select'); - - await select.click(); - await ionAlertDidPresent.next(); - - const alert = page.locator('ion-alert'); - const radioButtons = alert.locator('.alert-radio-button'); - const confirmButton = alert.locator('.alert-button:not(.alert-button-role-cancel)'); - - await radioButtons.nth(0).click(); - await confirmButton.click(); - - await ionChange.next(); - expect(ionChange).toHaveReceivedEventDetail({ value: 'apple' }); - }); - - test('should fire ionChange when confirming a value from a popover', async ({ page }) => { - await page.setContent( - ` - - Apple - Banana - - `, - config - ); - - const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent'); - const ionChange = await page.spyOnEvent('ionChange'); - const select = page.locator('ion-select'); - - await select.click(); - await ionPopoverDidPresent.next(); - - const popover = page.locator('ion-popover'); - const radioButtons = popover.locator('ion-radio'); - - await radioButtons.nth(0).click(); - - await ionChange.next(); - expect(ionChange).toHaveReceivedEventDetail({ value: 'apple', event: { isTrusted: true } }); - }); - - test('should fire ionChange when confirming a value from an action sheet', async ({ page }) => { - await page.setContent( - ` - - Apple - Banana - - `, - config - ); - - const ionActionSheetDidPresent = await page.spyOnEvent('ionActionSheetDidPresent'); - const ionChange = await page.spyOnEvent('ionChange'); - const select = page.locator('ion-select'); - - await select.click(); - await ionActionSheetDidPresent.next(); - - const actionSheet = page.locator('ion-action-sheet'); - const buttons = actionSheet.locator('.action-sheet-button'); - - await buttons.nth(0).click(); - - await ionChange.next(); - expect(ionChange).toHaveReceivedEventDetail({ value: 'apple' }); - }); - - test('should not fire when programmatically setting a valid value', async ({ page }) => { - await page.setContent( - ` - - Apple - Banana - - `, - config - ); - - const ionChange = await page.spyOnEvent('ionChange'); - const select = page.locator('ion-select'); - - await select.evaluate((el: HTMLIonSelectElement) => (el.value = 'banana')); - await expect(ionChange).not.toHaveReceivedEvent(); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/compare-with/index.html b/core/src/components/select/test/legacy/compare-with/index.html deleted file mode 100644 index 44a075f3ba..0000000000 --- a/core/src/components/select/test/legacy/compare-with/index.html +++ /dev/null @@ -1,74 +0,0 @@ - - - - - Select - compareWith - - - - - - - - - - - - - Select - compareWith - - - - - - - Select multiple using objects and compareWith - - - - Select using objects and compareWith - - - - - - - - - diff --git a/core/src/components/select/test/legacy/compare-with/select.e2e.ts b/core/src/components/select/test/legacy/compare-with/select.e2e.ts deleted file mode 100644 index c22b6da257..0000000000 --- a/core/src/components/select/test/legacy/compare-with/select.e2e.ts +++ /dev/null @@ -1,76 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -/** - * This behavior does not vary across modes/directions. - */ -configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe(title('select: compare-with'), () => { - test('should correctly set value when using compareWith property', async ({ page }) => { - await page.goto('/src/components/select/test/legacy/compare-with', config); - - const multipleSelect = page.locator('#multiple'); - const singleSelect = page.locator('#single'); - - await expect(multipleSelect).toHaveJSProperty('value', [ - { - label: 'selected by default', - value: '1', - }, - ]); - await expect(singleSelect).toHaveJSProperty('value', { - label: 'selected by default', - value: '1', - }); - }); - - test('should work with different parameter types', async ({ page }) => { - test.info().annotations.push({ - type: 'issue', - description: 'https://github.com/ionic-team/ionic-framework/issues/25759', - }); - - await page.setContent( - ` - - - - `, - config - ); - const ionAlertDidPresent = await page.spyOnEvent('ionAlertDidPresent'); - - const select = page.locator('ion-select'); - const selectLabel = select.locator('[part="text"]'); - - await expect(selectLabel).toHaveText('Option #3'); - - await select.click(); - await ionAlertDidPresent.next(); - - const selectRadios = page.locator('ion-alert button.alert-radio'); - await expect(selectRadios.nth(0)).toHaveAttribute('aria-checked', 'false'); - await expect(selectRadios.nth(1)).toHaveAttribute('aria-checked', 'false'); - await expect(selectRadios.nth(2)).toHaveAttribute('aria-checked', 'true'); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/conflict/index.html b/core/src/components/select/test/legacy/conflict/index.html deleted file mode 100644 index e7c775e1d8..0000000000 --- a/core/src/components/select/test/legacy/conflict/index.html +++ /dev/null @@ -1,82 +0,0 @@ - - - - - Select - Basic - - - - - - - - - - - - - Select - Conflict - - - - - - - Alert - - Unselected - Zero - Empty String - Null - - - - - Action-sheet - - Unselected - Zero - Empty String - Null - - - - - Popover - - Unselected - Zero - Empty String - Null - - - - - - - - - - - diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts b/core/src/components/select/test/legacy/custom/custom.e2e.ts deleted file mode 100644 index fb0cdfff57..0000000000 --- a/core/src/components/select/test/legacy/custom/custom.e2e.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs().forEach(({ title, screenshot, config }) => { - test.describe(title('select: custom'), () => { - test('should not have visual regressions', async ({ page }) => { - await page.goto(`/src/components/select/test/legacy/custom`, config); - - await expect(page).toHaveScreenshot(screenshot(`select-custom-diff`)); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 176404d1ec..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 095645c555..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index a9c10889e2..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index 81ba7554a3..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 4e7aaa7914..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 3c1feca183..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 0c557935d1..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 92899d7fdd..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index cb0f6ab586..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index ee73c5f892..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 23dc92e89b..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index a63ad8b49d..0000000000 Binary files a/core/src/components/select/test/legacy/custom/custom.e2e.ts-snapshots/select-custom-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/custom/index.html b/core/src/components/select/test/legacy/custom/index.html deleted file mode 100644 index 54991c3edb..0000000000 --- a/core/src/components/select/test/legacy/custom/index.html +++ /dev/null @@ -1,205 +0,0 @@ - - - - - Select - Custom - - - - - - - - - - - - - Select - Custom - - - - - - - Standalone Select - - - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - Item Select - - - - Location - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - - - - Custom Options - - - - Default Interface (Alert) - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - - Action Sheet Interface - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - - Popover Interface - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - - Default Interface (Alert): Multiple - - Madison, WI - Austin, TX - Chicago, IL - Seattle, WA - - - - - - - - - - - diff --git a/core/src/components/select/test/legacy/label/index.html b/core/src/components/select/test/legacy/label/index.html deleted file mode 100644 index 5fe2652c22..0000000000 --- a/core/src/components/select/test/legacy/label/index.html +++ /dev/null @@ -1,68 +0,0 @@ - - - - - Select - Basic - - - - - - - - - - - - - Select - Labels - - - - - - - Gender - - Female - Male - - - - - Hair Color - - Brown - Empty Value - Black - Red - - - - - Hair Color - - Brown - Blonde - Black - Red - - - - - Hair Color - - Brown - Blonde - Black - Red - - - - - - - diff --git a/core/src/components/select/test/legacy/multiple-value/index.html b/core/src/components/select/test/legacy/multiple-value/index.html deleted file mode 100644 index a36d77d531..0000000000 --- a/core/src/components/select/test/legacy/multiple-value/index.html +++ /dev/null @@ -1,166 +0,0 @@ - - - - - Select - Multiple Value - - - - - - - - - - - - - Select Item: Multiple Value - - - - - - Toppings - - Bacon - Black Olives - Extra Cheese - Green Peppers - Mushrooms - Onions - Pepperoni - Pineapple - Sausage - Spinach - - - - - Car Features - - Backup Camera - Headted Seats - Keyless Entry - Navigation - Parking Assist - Sun Roof - - - - - Pets - - Cat - Dog - Turtle - Fish - - - - - Disabled - - Selected Text - - - - - Statuses - - Selected - Default - Disabled - - - - - -
- - - - - - Select - - 1 - 2 - 3 - - - Submit - -
- - - Floating label - - Bacon - Black Olives - Extra Cheese - Green Peppers - Mushrooms - Onions - Pepperoni - Pineapple - Sausage - Spinach - - - - - - - - - - diff --git a/core/src/components/select/test/legacy/single-value/index.html b/core/src/components/select/test/legacy/single-value/index.html deleted file mode 100644 index 741610efcd..0000000000 --- a/core/src/components/select/test/legacy/single-value/index.html +++ /dev/null @@ -1,268 +0,0 @@ - - - - - Select - Single Value - - - - - - - - - - - - - Select Item: Single Value - - - - - - Gender - - Female - Male - - - - - Popover - - Select - Action Sheet - Popover - - - - - Gaming - - NES - Nintendo64 - PlayStation - Sega Genesis - Sega Saturn - SNES - - - - - Operating System - - DOS - Linux - Mac OS 7 - Mac OS 8 - Windows 3.1 - Windows 95 - Windows 98 - - - - - Notifications - - Enable - Mute - Mute for a week - Mute for a year - - - - - Edit - - Add Reaction - Copy Text - Share Text - Copy Link to Message - Remind Me - Pin File - Star File - Mark Unread - Edit Title - Save Image - Copy Image - Delete File - - - - - Music - - Alice in Chains - Green Day - Nirvana - Pearl Jam - Smashing Pumpkins - Soundgarden - Stone Temple Pilots - - - - - Date - - January - February - March - April - May - June - July - August - September - October - November - December - - - - - - Statuses - - Selected - Default - Disabled - - - - - Currency - - - - Reset Gender - - - - - - - - - - diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts b/core/src/components/select/test/legacy/single-value/select.e2e.ts deleted file mode 100644 index 06d8dc8de3..0000000000 --- a/core/src/components/select/test/legacy/single-value/select.e2e.ts +++ /dev/null @@ -1,18 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { - test.describe(title('select: single-value'), () => { - test('should open single value select', async ({ page }) => { - await page.goto(`/src/components/select/test/legacy/single-value`, config); - - const ionAlertDidPresent = await page.spyOnEvent('ionAlertDidPresent'); - - await page.click('#gender'); - - await ionAlertDidPresent.next(); - - await expect(page).toHaveScreenshot(screenshot(`select-single-value-diff`)); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 0354a1da9a..0000000000 Binary files a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 86712f36e3..0000000000 Binary files a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index c22a92ed5e..0000000000 Binary files a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index ab5a8f7c6e..0000000000 Binary files a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 059388e37e..0000000000 Binary files a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 007bb3cbc7..0000000000 Binary files a/core/src/components/select/test/legacy/single-value/select.e2e.ts-snapshots/select-single-value-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/index.html b/core/src/components/select/test/legacy/spec/index.html deleted file mode 100644 index 66c15e3182..0000000000 --- a/core/src/components/select/test/legacy/spec/index.html +++ /dev/null @@ -1,455 +0,0 @@ - - - - - Select - Spec - - - - - - - - - - - - - Select - Spec - - - -

Floating Selects

- -
-
-

Default

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Default: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
- -
- -

Stacked Selects

- -
-
-

Default

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Default: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
- -
- -

Inline Selects

- -
-
-

Default

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Default: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
- -
- -

Fixed Selects

- -
-
-

Default

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Default: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Filled: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined

- - - Fruit - - - Apple - Orange - Banana - - -
-
-

Outlined: Focused

- - - Fruit - - - Apple - Orange - Banana - - -
-
- -
- -

Full Width Selects

- - - - Inline - - - Apple - Orange - Banana - - - - - Fixed - - - Apple - Orange - Banana - - - - - Floating - - - Apple - Orange - Banana - - - - - Stacked - - - Apple - Orange - Banana - - - - -
- - - - - - diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts b/core/src/components/select/test/legacy/spec/select.e2e.ts deleted file mode 100644 index df22e5d794..0000000000 --- a/core/src/components/select/test/legacy/spec/select.e2e.ts +++ /dev/null @@ -1,14 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs().forEach(({ title, screenshot, config }) => { - test.describe(title('select: spec'), () => { - test('should not have visual regressions', async ({ page }) => { - await page.goto(`/src/components/select/test/legacy/spec`, config); - - await page.setIonViewport(); - - await expect(page).toHaveScreenshot(screenshot(`select-spec-diff`)); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index f09c48b6cd..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 7315e2b242..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 53d5e173b1..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index cd4713e9bd..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index 8c71d2ef70..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index ed0ffb5a1d..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 7b23df30fd..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index d81c25dfed..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index f9ba4e441c..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index fd42c1e8e2..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index fb13554e1a..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index c5fa4e9983..0000000000 Binary files a/core/src/components/select/test/legacy/spec/select.e2e.ts-snapshots/select-spec-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/standalone/index.html b/core/src/components/select/test/legacy/standalone/index.html deleted file mode 100644 index 7ffb75e6c1..0000000000 --- a/core/src/components/select/test/legacy/standalone/index.html +++ /dev/null @@ -1,85 +0,0 @@ - - - - - Select - Standalone - - - - - - - - - - - Female - Male - - - - Brown - Blonde - Black - Red - - - - Popover - NES - Nintendo64 - PlayStation - Sega Genesis - Sega Saturn - SNES - - - - January - February - March - April - May - June - July - August - September - October - November - December - - - - 1989 - 1990 - 1991 - 1992 - 1993 - 1994 - 1995 - 1996 - 1997 - 1998 - 1999 - - - - Sunday - Monday - Tuesday - Wednesday - Thursday - Friday - Saturday - - - - - diff --git a/core/src/components/select/test/legacy/standalone/select.e2e.ts b/core/src/components/select/test/legacy/standalone/select.e2e.ts deleted file mode 100644 index bfb7c8130a..0000000000 --- a/core/src/components/select/test/legacy/standalone/select.e2e.ts +++ /dev/null @@ -1,20 +0,0 @@ -import { configs, test } from '@utils/test/playwright'; - -configs({ directions: ['ltr'] }).forEach(({ title, config }) => { - test.describe(title('select: standalone'), () => { - test('should open an overlay without ion-app', async ({ page }) => { - await page.goto(`/src/components/select/test/legacy/standalone`, config); - const ionAlertDidPresent = await page.spyOnEvent('ionAlertDidPresent'); - const ionAlertDidDismiss = await page.spyOnEvent('ionAlertDidDismiss'); - - await page.click('#gender'); - - await ionAlertDidPresent.next(); - - const alert = page.locator('ion-alert'); - await alert.evaluate((el: HTMLIonAlertElement) => el.dismiss()); - - await ionAlertDidDismiss.next(); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts b/core/src/components/select/test/legacy/wrapping/select.e2e.ts deleted file mode 100644 index 5e8daa7dd9..0000000000 --- a/core/src/components/select/test/legacy/wrapping/select.e2e.ts +++ /dev/null @@ -1,51 +0,0 @@ -import { expect } from '@playwright/test'; -import { configs, test } from '@utils/test/playwright'; - -configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { - test.describe(title('select: wrapping'), () => { - test('should not wrap text by default', async ({ page }) => { - await page.setContent( - ` - - Should not wrap when no label exists and no class is added to make the text wrap - - `, - config - ); - - const select = page.locator('ion-select'); - await expect(select).toHaveScreenshot(screenshot(`select-nowrap`)); - }); - - test('should wrap text with class', async ({ page }) => { - await page.setContent( - ` - - Should wrap when no label exists and really long text exists to make it wrap the text - - `, - config - ); - - const select = page.locator('ion-select'); - await expect(select).toHaveScreenshot(screenshot(`select-wrap`)); - }); - - test('should not wrap label while wrapping text with class', async ({ page }) => { - await page.setContent( - ` - - Really long label should not wrap - - Should wrap value only when label exists and really long text exists to make it wrap the text - - - `, - config - ); - - const select = page.locator('ion-item'); - await expect(select).toHaveScreenshot(screenshot(`select-wrap-with-label`)); - }); - }); -}); diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 2aaeddeb28..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 4cc95981f9..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index b6bc80740b..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index c2169b773c..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 6846271eaf..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 1a9f3c1eb9..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-nowrap-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 086cb2efbb..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 3b475102b0..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index c4aaa45f69..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 2214bfd095..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 075f6ff2db..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index bc53217185..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index d0229a0bc3..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 3ed9dc3758..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 89af3b2593..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Chrome-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 148bbbf82f..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Firefox-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 47313fde4b..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Safari-linux.png b/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index ee5e0749b6..0000000000 Binary files a/core/src/components/select/test/legacy/wrapping/select.e2e.ts-snapshots/select-wrap-with-label-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/packages/angular/src/directives/proxies.ts b/packages/angular/src/directives/proxies.ts index 169f7523c3..df360fc2cd 100644 --- a/packages/angular/src/directives/proxies.ts +++ b/packages/angular/src/directives/proxies.ts @@ -1975,7 +1975,7 @@ export declare interface IonSegmentButton extends Components.IonSegmentButton {} @ProxyCmp({ - inputs: ['cancelText', 'color', 'compareWith', 'disabled', 'expandedIcon', 'fill', 'interface', 'interfaceOptions', 'justify', 'label', 'labelPlacement', 'legacy', 'mode', 'multiple', 'name', 'okText', 'placeholder', 'selectedText', 'shape', 'toggleIcon', 'value'], + inputs: ['cancelText', 'color', 'compareWith', 'disabled', 'expandedIcon', 'fill', 'interface', 'interfaceOptions', 'justify', 'label', 'labelPlacement', 'mode', 'multiple', 'name', 'okText', 'placeholder', 'selectedText', 'shape', 'toggleIcon', 'value'], methods: ['open'] }) @Component({ @@ -1983,7 +1983,7 @@ export declare interface IonSegmentButton extends Components.IonSegmentButton {} changeDetection: ChangeDetectionStrategy.OnPush, template: '', // eslint-disable-next-line @angular-eslint/no-inputs-metadata-property - inputs: ['cancelText', 'color', 'compareWith', 'disabled', 'expandedIcon', 'fill', 'interface', 'interfaceOptions', 'justify', 'label', 'labelPlacement', 'legacy', 'mode', 'multiple', 'name', 'okText', 'placeholder', 'selectedText', 'shape', 'toggleIcon', 'value'], + inputs: ['cancelText', 'color', 'compareWith', 'disabled', 'expandedIcon', 'fill', 'interface', 'interfaceOptions', 'justify', 'label', 'labelPlacement', 'mode', 'multiple', 'name', 'okText', 'placeholder', 'selectedText', 'shape', 'toggleIcon', 'value'], }) export class IonSelect { protected el: HTMLElement; diff --git a/packages/angular/standalone/src/directives/select.ts b/packages/angular/standalone/src/directives/select.ts index fa194b6ad5..973990f5c8 100644 --- a/packages/angular/standalone/src/directives/select.ts +++ b/packages/angular/standalone/src/directives/select.ts @@ -28,7 +28,6 @@ const SELECT_INPUTS = [ 'justify', 'label', 'labelPlacement', - 'legacy', 'mode', 'multiple', 'name', diff --git a/packages/vue/src/proxies.ts b/packages/vue/src/proxies.ts index 8be5e900f5..ba6d8f163b 100644 --- a/packages/vue/src/proxies.ts +++ b/packages/vue/src/proxies.ts @@ -758,7 +758,6 @@ export const IonSelect = /*@__PURE__*/ defineContainer