From 6baf005da5be8c244a781bbffbcffca1a2ff90dc Mon Sep 17 00:00:00 2001 From: Sean Perkins <13732623+sean-perkins@users.noreply.github.com> Date: Tue, 13 Feb 2024 20:44:26 -0500 Subject: [PATCH] feat(angular): remove IonBackButtonDelegate (#29030) Issue number: Internal --------- ## What is the current behavior? We currently export two versions of the `ion-back-button` angular implementation: `IonBackButton` and `IonBackButtonDelegate`. ## What is the new behavior? - Removes `IonBackButtonDelegate` in favor of `IonBackButton` ## Does this introduce a breaking change? - [x] Yes - [ ] No - The `IonBackButtonDelegate` class has been removed in favor of `IonBackButton`. ```diff - import { IonBackButtonDelegate } from '@ionic/angular'; + import { IonBackButton } from '@ionic/angular'; ``` ## Other information --- BREAKING.md | 15 ++++++++++++++- packages/angular/src/index.ts | 2 -- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/BREAKING.md b/BREAKING.md index 3f3e4ad0fa..86152d156c 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -29,6 +29,8 @@ This is a comprehensive list of the breaking changes introduced in the major ver - [Select](#version-8x-select) - [Textarea](#version-8x-textarea) - [Toggle](#version-8x-toggle) +- [Framework Specific](#version-8x-framework-specific) + - [Angular](#version-8x-angular)

Browser and Platform Support

@@ -198,4 +200,15 @@ For more information on styling toast buttons, refer to the [Toast Theming docum

Toggle

-- The `legacy` property and support for the legacy syntax, which involved placing an `ion-toggle` inside of an `ion-item` with an `ion-label`, have been removed. For more information on migrating from the legacy toggle syntax, refer to the [Toggle documentation](https://ionicframework.com/docs/api/toggle#migrating-from-legacy-toggle-syntax). \ No newline at end of file +- The `legacy` property and support for the legacy syntax, which involved placing an `ion-toggle` inside of an `ion-item` with an `ion-label`, have been removed. For more information on migrating from the legacy toggle syntax, refer to the [Toggle documentation](https://ionicframework.com/docs/api/toggle#migrating-from-legacy-toggle-syntax). + +

Framework Specific

+ +

Angular

+ +- The `IonBackButtonDelegate` class has been removed in favor of `IonBackButton`. + + ```diff + - import { IonBackButtonDelegate } from '@ionic/angular'; + + import { IonBackButton } from '@ionic/angular'; + ``` diff --git a/packages/angular/src/index.ts b/packages/angular/src/index.ts index b0c99d1557..da4a6c549c 100644 --- a/packages/angular/src/index.ts +++ b/packages/angular/src/index.ts @@ -5,8 +5,6 @@ export { SelectValueAccessorDirective as SelectValueAccessor } from './directive export { TextValueAccessorDirective as TextValueAccessor } from './directives/control-value-accessors/text-value-accessor'; export { IonTabs } from './directives/navigation/ion-tabs'; export { IonBackButton } from './directives/navigation/ion-back-button'; -// TODO FW-5889 -export { IonBackButton as IonBackButtonDelegate } from './directives/navigation/ion-back-button'; export { IonNav } from './directives/navigation/ion-nav'; export { IonRouterOutlet } from './directives/navigation/ion-router-outlet'; export {