From 69920157e229b5e1d0ef054dcef81bdbdaaa2f5c Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Mon, 31 Mar 2014 13:54:23 -0500 Subject: [PATCH] remove global regex variable --- js/views/scrollView.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/js/views/scrollView.js b/js/views/scrollView.js index d13c4dec3e..097dd1964c 100644 --- a/js/views/scrollView.js +++ b/js/views/scrollView.js @@ -1,5 +1,3 @@ -var IS_INPUT_LIKE_REGEX = /input|textarea|select/i; -var IS_EMBEDDED_OBJECT_REGEX = /object|embed/i; /* * Scroller * http://github.com/zynga/scroller @@ -620,10 +618,9 @@ ionic.views.Scroll = ionic.views.View.inherit({ function shouldIgnorePress(e) { // Don't react if initial down happens on a form element - return e.target.tagName.match(IS_INPUT_LIKE_REGEX) || + return e.target.tagName.match(/input|textarea|select|object|embed/i) || e.target.isContentEditable || - e.target.tagName.match(IS_EMBEDDED_OBJECT_REGEX) || - e.target.dataset ? e.target.dataset.preventScroll : e.target.getAttribute('data-prevent-default') == 'true'; + (e.target.dataset ? e.target.dataset.preventScroll : e.target.getAttribute('data-prevent-default') == 'true'); }