javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(angular): disable change detection detach

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-12-05 22:23:19 +01:00
committed by Manu MA
parent 945dd2610b
commit 68e26192a5
12 changed files with 71 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
angular/src/directives/navigation/stack-controller.ts
View File

@ -106,7 +106,8 @@ export class StackController {
const element = view.element;
element.setAttribute('aria-hidden', 'true');
element.classList.add('ion-page-hidden');
view.ref.changeDetectorRef.detach();
// TODO
// view.ref.changeDetectorRef.detach();
}
this.viewsSnapshot = views.slice();
}
@ -132,10 +133,11 @@ export class StackController {
this.skipTransition = false;
return;
}
if (enteringView) {
enteringView.ref.changeDetectorRef.reattach();
enteringView.ref.changeDetectorRef.markForCheck();
}
// TODO
// if (enteringView) {
// enteringView.ref.changeDetectorRef.reattach();
// enteringView.ref.changeDetectorRef.markForCheck();
// }
const enteringEl = enteringView ? enteringView.element : undefined;
const leavingEl = leavingView ? leavingView.element : undefined;
const containerEl = this.containerEl;