octicon-mirror(24/)
javascript/ionic-framework
octicon-rss(16/)
1
0
octicon-repo-forked(16/)Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 22:44:13 +08:00
octicon-code(16/) Code octicon-issue-opened(16/) Issues octicon-package(16/) Packages octicon-project(16/) Projects octicon-tag(16/) Releases octicon-book(16/) Wiki octicon-pulse(16/) Activity

fix(angular): disable change detection detach

Browse Source
This commit is contained in:
octicon-git-branch(16/)
octicon-tag(16/)
Manu Mtz.-Almeida
2018-12-05 22:23:19 +01:00
committed by Manu MA
gitea-unlock(16/)
parent 945dd2610b
commit 68e26192a5
octicon-diff(16/tw-mr-1) 12 changed files with 71 additions and 24 deletions
gitea-whitespace(16/)
gitea-split(16/)
octicon-kebab-horizontal(16/)
Download Patch File Download Diff File Expand all files Collapse all files

12
angular/src/directives/navigation/stack-controller.ts
View File

@@ -106,7 +106,8 @@ export class StackController {
const element = view.element;
element.setAttribute('aria-hidden', 'true');
element.classList.add('ion-page-hidden');
view.ref.changeDetectorRef.detach();
// TODO
// view.ref.changeDetectorRef.detach();
}
this.viewsSnapshot = views.slice();
}
@@ -132,10 +133,11 @@ export class StackController {
this.skipTransition = false;
return;
}
if (enteringView) {
enteringView.ref.changeDetectorRef.reattach();
enteringView.ref.changeDetectorRef.markForCheck();
}
// TODO
// if (enteringView) {
// enteringView.ref.changeDetectorRef.reattach();
// enteringView.ref.changeDetectorRef.markForCheck();
// }
const enteringEl = enteringView ? enteringView.element : undefined;
const leavingEl = leavingView ? leavingView.element : undefined;
const containerEl = this.containerEl;