javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 10:01:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(slides): fix mutable options

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-09-15 10:28:16 +02:00
parent 7bc9a077ca
commit 681981fc89
7 changed files with 241 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/src/components/slides/slides.tsx
View File

@ -38,10 +38,12 @@ export class Slides implements ComponentInterface {
@Prop() options: any = {}; // SwiperOptions; // TODO
@Watch('options')
async updateSwiperOptions() {
const swiper = await this.getSwiper();
swiper.params = this.normalizeOptions();
await this.update();
async optionsChanged() {
if (this.didInit) {
const swiper = await this.getSwiper();
Object.assign(swiper.params, this.options);
await this.update();
}
}
/**
@ -173,9 +175,9 @@ export class Slides implements ComponentInterface {
* Transition to the next slide.
*/
@Method()
async slideNext(speed: number, runCallbacks: boolean) {
async slideNext(speed?: number, runCallbacks?: boolean) {
const swiper = await this.getSwiper();
swiper.slideNext(speed, runCallbacks);
swiper.slideNext(speed!, runCallbacks!);
}
/**