From 67ea34ae1d2c1d1f9bd9fd61e32559efd174ce96 Mon Sep 17 00:00:00 2001 From: Felquis Gimenes Date: Wed, 14 May 2014 11:43:17 -0300 Subject: [PATCH] docs($ionicModal): clearly note that `.modal` wrapper is required Closes #1384. Just to avoid mistakes/questions like this http://forum.ionicframework.com/t/ionic-modal-not-animating/4196 --- js/angular/controller/scrollController.js | 2 -- js/angular/service/modal.js | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/js/angular/controller/scrollController.js b/js/angular/controller/scrollController.js index 024cc4cca7..c8619118f3 100644 --- a/js/angular/controller/scrollController.js +++ b/js/angular/controller/scrollController.js @@ -165,8 +165,6 @@ function($scope, scrollViewOptions, $timeout, $window, $$scrollValueCache, $loca } }; - - /** * @private */ diff --git a/js/angular/service/modal.js b/js/angular/service/modal.js index ad5aa75375..b95ef007d3 100644 --- a/js/angular/service/modal.js +++ b/js/angular/service/modal.js @@ -4,7 +4,8 @@ * @module ionic * @description * The Modal is a content pane that can go over the user's main view - * temporarily. Usually used for making a choice or editing an item. + * temporarily. Usually used for making a choice or editing an item. + * Note that you need to put the content of the modal inside a div with the class `modal`. * * @usage * ```html