javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 02:31:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): checking isOpen again after async call before opening overlay, fixes #19755

Browse Source
This commit is contained in:
Ely Lucas
2019-10-28 10:20:45 -06:00
parent 29f8178794
commit 67737bbb54
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/react/src/components/createControllerComponent.tsx
View File

@ -54,13 +54,19 @@ export const createControllerComponent = <OptionsType extends object, OverlayTyp
async present(prevProps?: Props) { async present(prevProps?: Props) {
const { isOpen, onDidDismiss, ...cProps } = this.props; const { isOpen, onDidDismiss, ...cProps } = this.props;
const overlay = this.overlay = await controller.create({ let overlay = this.overlay;
...cProps as any if (!overlay) {
}); overlay = this.overlay = await controller.create({
...cProps as any
});
}
attachProps(overlay, { attachProps(overlay, {
[dismissEventName]: onDidDismiss [dismissEventName]: onDidDismiss
}, prevProps); }, prevProps);
await overlay.present(); // Check isOpen again since the value could of changed during the async call to controller.create
if (this.props.isOpen === true) {
await overlay.present();
}
} }
render(): null { render(): null {