From 642faed2721957dadb63b89ab7b69cc0abc97ea1 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 27 Apr 2023 10:48:55 -0400 Subject: [PATCH] test(breadcrumbs): migrate to generators (#27291) Issue number: N/A --------- ## What is the current behavior? - Breadcrumbs uses legacy test format ## What is the new behavior? - Breadcrumbs uses generator syntax ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- .../test/a11y/breadcrumbs.e2e-legacy.ts | 12 --- .../breadcrumbs/test/a11y/breadcrumbs.e2e.ts | 14 ++++ .../test/basic/breadcrumbs.e2e-legacy.ts | 12 --- .../breadcrumbs/test/basic/breadcrumbs.e2e.ts | 14 ++++ ...crumb-diff-ios-ltr-Mobile-Chrome-linux.png | Bin ...rumb-diff-ios-ltr-Mobile-Firefox-linux.png | Bin ...crumb-diff-ios-ltr-Mobile-Safari-linux.png | Bin ...crumb-diff-ios-rtl-Mobile-Chrome-linux.png | Bin ...rumb-diff-ios-rtl-Mobile-Firefox-linux.png | Bin ...crumb-diff-ios-rtl-Mobile-Safari-linux.png | Bin ...dcrumb-diff-md-ltr-Mobile-Chrome-linux.png | Bin ...crumb-diff-md-ltr-Mobile-Firefox-linux.png | Bin ...dcrumb-diff-md-ltr-Mobile-Safari-linux.png | Bin ...dcrumb-diff-md-rtl-Mobile-Chrome-linux.png | Bin ...crumb-diff-md-rtl-Mobile-Firefox-linux.png | Bin ...dcrumb-diff-md-rtl-Mobile-Safari-linux.png | Bin .../test/collapsed/breadcrumbs.e2e-legacy.ts | 12 --- .../test/collapsed/breadcrumbs.e2e.ts | 14 ++++ ...apsed-diff-ios-ltr-Mobile-Chrome-linux.png | Bin ...psed-diff-ios-ltr-Mobile-Firefox-linux.png | Bin ...apsed-diff-ios-ltr-Mobile-Safari-linux.png | Bin ...apsed-diff-ios-rtl-Mobile-Chrome-linux.png | Bin ...psed-diff-ios-rtl-Mobile-Firefox-linux.png | Bin ...apsed-diff-ios-rtl-Mobile-Safari-linux.png | Bin ...lapsed-diff-md-ltr-Mobile-Chrome-linux.png | Bin ...apsed-diff-md-ltr-Mobile-Firefox-linux.png | Bin ...lapsed-diff-md-ltr-Mobile-Safari-linux.png | Bin ...lapsed-diff-md-rtl-Mobile-Chrome-linux.png | Bin ...apsed-diff-md-rtl-Mobile-Firefox-linux.png | Bin ...lapsed-diff-md-rtl-Mobile-Safari-linux.png | Bin .../test/reactive/breadcrumbs.e2e-legacy.ts | 71 ------------------ .../test/reactive/breadcrumbs.e2e.ts | 70 +++++++++++++++++ ...ve-add-diff-md-ltr-Mobile-Chrome-linux.png | Bin ...e-add-diff-md-ltr-Mobile-Firefox-linux.png | Bin ...ve-add-diff-md-ltr-Mobile-Safari-linux.png | Bin ...remove-diff-md-ltr-Mobile-Chrome-linux.png | Bin ...emove-diff-md-ltr-Mobile-Firefox-linux.png | Bin ...remove-diff-md-ltr-Mobile-Safari-linux.png | Bin 38 files changed, 112 insertions(+), 107 deletions(-) delete mode 100644 core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e-legacy.ts create mode 100644 core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e.ts delete mode 100644 core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts create mode 100644 core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/basic/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png (100%) delete mode 100644 core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts create mode 100644 core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/collapsed/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png (100%) delete mode 100644 core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts create mode 100644 core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts rename core/src/components/breadcrumbs/test/reactive/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/reactive/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/reactive/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Safari-linux.png (100%) rename core/src/components/breadcrumbs/test/reactive/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Chrome-linux.png (100%) rename core/src/components/breadcrumbs/test/reactive/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Firefox-linux.png (100%) rename core/src/components/breadcrumbs/test/reactive/{breadcrumbs.e2e-legacy.ts-snapshots => breadcrumbs.e2e.ts-snapshots}/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Safari-linux.png (100%) diff --git a/core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e-legacy.ts b/core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e-legacy.ts deleted file mode 100644 index adc70f5b03..0000000000 --- a/core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e-legacy.ts +++ /dev/null @@ -1,12 +0,0 @@ -import AxeBuilder from '@axe-core/playwright'; -import { expect } from '@playwright/test'; -import { test } from '@utils/test/playwright'; - -test.describe('breadcrumbs: axe', () => { - test('should not have accessibility violations', async ({ page }) => { - await page.goto(`/src/components/breadcrumbs/test/a11y`); - - const results = await new AxeBuilder({ page }).analyze(); - expect(results.violations).toEqual([]); - }); -}); diff --git a/core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e.ts new file mode 100644 index 0000000000..127c0f941f --- /dev/null +++ b/core/src/components/breadcrumbs/test/a11y/breadcrumbs.e2e.ts @@ -0,0 +1,14 @@ +import AxeBuilder from '@axe-core/playwright'; +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs().forEach(({ config, title }) => { + test.describe(title('breadcrumbs: axe'), () => { + test('should not have accessibility violations', async ({ page }) => { + await page.goto(`/src/components/breadcrumbs/test/a11y`, config); + + const results = await new AxeBuilder({ page }).analyze(); + expect(results.violations).toEqual([]); + }); + }); +}); diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts deleted file mode 100644 index e5a8907d27..0000000000 --- a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { expect } from '@playwright/test'; -import { test } from '@utils/test/playwright'; - -test.describe('breadcrumbs: basic', () => { - test('should not have visual regressions', async ({ page }) => { - await page.goto(`/src/components/breadcrumbs/test/basic`); - - await page.setIonViewport(); - - await expect(page).toHaveScreenshot(`breadcrumb-diff-${page.getSnapshotSettings()}.png`); - }); -}); diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts new file mode 100644 index 0000000000..a82f885a31 --- /dev/null +++ b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts @@ -0,0 +1,14 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs().forEach(({ config, screenshot, title }) => { + test.describe(title('breadcrumbs: basic'), () => { + test('should not have visual regressions', async ({ page }) => { + await page.goto(`/src/components/breadcrumbs/test/basic`, config); + + await page.setIonViewport(); + + await expect(page).toHaveScreenshot(screenshot(`breadcrumb-diff`)); + }); + }); +}); diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts deleted file mode 100644 index 8709bf1e6b..0000000000 --- a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts +++ /dev/null @@ -1,12 +0,0 @@ -import { expect } from '@playwright/test'; -import { test } from '@utils/test/playwright'; - -test.describe('breadcrumbs: collapsed', () => { - test('should not have visual regressions', async ({ page }) => { - await page.goto(`/src/components/breadcrumbs/test/collapsed`); - - await page.setIonViewport(); - - await expect(page).toHaveScreenshot(`breadcrumb-collapsed-diff-${page.getSnapshotSettings()}.png`); - }); -}); diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts new file mode 100644 index 0000000000..a9e9efbbaf --- /dev/null +++ b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts @@ -0,0 +1,14 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs().forEach(({ config, screenshot, title }) => { + test.describe(title('breadcrumbs: collapsed'), () => { + test('should not have visual regressions', async ({ page }) => { + await page.goto(`/src/components/breadcrumbs/test/collapsed`, config); + + await page.setIonViewport(); + + await expect(page).toHaveScreenshot(screenshot(`breadcrumb-collapsed-diff`)); + }); + }); +}); diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts deleted file mode 100644 index 4bd1b027c3..0000000000 --- a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts +++ /dev/null @@ -1,71 +0,0 @@ -import { expect } from '@playwright/test'; -import { test } from '@utils/test/playwright'; - -test.describe('breadcrumbs: reactive', () => { - test.beforeEach(async ({ page, skip }) => { - skip.rtl(); - skip.mode('ios'); - - await page.goto(`/src/components/breadcrumbs/test/reactive`); - }); - - test.describe('adding a breadcrumb item', () => { - test('should update the active item', async ({ page }) => { - const breadcrumbItems = page.locator('ion-breadcrumb'); - - const addItemButton = page.locator('ion-button#add-btn'); - - await expect(breadcrumbItems).toHaveCount(4); - - await addItemButton.click(); - await page.waitForChanges(); - - await expect(breadcrumbItems).toHaveCount(5); - - const previousActiveItem = breadcrumbItems.nth(3); - const lastBreadcrumbItem = breadcrumbItems.nth(4); - - await expect(previousActiveItem).not.toHaveClass(/breadcrumb-active/); - await expect(lastBreadcrumbItem).toHaveClass(/breadcrumb-active/); - }); - - test('should not have visual regressions', async ({ page }) => { - await page.setIonViewport(); - - const breadcrumbs = page.locator('ion-breadcrumbs'); - - await page.click('#add-btn'); - await page.waitForChanges(); - - await expect(breadcrumbs).toHaveScreenshot(`breadcrumbs-reactive-add-diff-${page.getSnapshotSettings()}.png`); - }); - }); - - test.describe('removing a breadcrumb item', () => { - test('should update the active item', async ({ page }) => { - const breadcrumbItems = page.locator('ion-breadcrumb'); - - await expect(breadcrumbItems).toHaveCount(4); - - await page.click('#remove-btn'); - await page.waitForChanges(); - - await expect(breadcrumbItems).toHaveCount(3); - - const lastBreadcrumbItem = breadcrumbItems.nth(2); - - await expect(lastBreadcrumbItem).toHaveClass(/breadcrumb-active/); - }); - - test('should not have visual regressions', async ({ page }) => { - await page.setIonViewport(); - - const breadcrumbs = page.locator('ion-breadcrumbs'); - - await page.click('#remove-btn'); - await page.waitForChanges(); - - await expect(breadcrumbs).toHaveScreenshot(`breadcrumbs-reactive-remove-diff-${page.getSnapshotSettings()}.png`); - }); - }); -}); diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts new file mode 100644 index 0000000000..b5bd6a384f --- /dev/null +++ b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts @@ -0,0 +1,70 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, screenshot, title }) => { + test.describe(title('breadcrumbs: reactive'), () => { + test.beforeEach(async ({ page }) => { + await page.goto(`/src/components/breadcrumbs/test/reactive`, config); + }); + + test.describe('adding a breadcrumb item', () => { + test('should update the active item', async ({ page }) => { + const breadcrumbItems = page.locator('ion-breadcrumb'); + + const addItemButton = page.locator('ion-button#add-btn'); + + await expect(breadcrumbItems).toHaveCount(4); + + await addItemButton.click(); + await page.waitForChanges(); + + await expect(breadcrumbItems).toHaveCount(5); + + const previousActiveItem = breadcrumbItems.nth(3); + const lastBreadcrumbItem = breadcrumbItems.nth(4); + + await expect(previousActiveItem).not.toHaveClass(/breadcrumb-active/); + await expect(lastBreadcrumbItem).toHaveClass(/breadcrumb-active/); + }); + + test('should not have visual regressions', async ({ page }) => { + await page.setIonViewport(); + + const breadcrumbs = page.locator('ion-breadcrumbs'); + + await page.click('#add-btn'); + await page.waitForChanges(); + + await expect(breadcrumbs).toHaveScreenshot(screenshot(`breadcrumbs-reactive-add-diff`)); + }); + }); + + test.describe('removing a breadcrumb item', () => { + test('should update the active item', async ({ page }) => { + const breadcrumbItems = page.locator('ion-breadcrumb'); + + await expect(breadcrumbItems).toHaveCount(4); + + await page.click('#remove-btn'); + await page.waitForChanges(); + + await expect(breadcrumbItems).toHaveCount(3); + + const lastBreadcrumbItem = breadcrumbItems.nth(2); + + await expect(lastBreadcrumbItem).toHaveClass(/breadcrumb-active/); + }); + + test('should not have visual regressions', async ({ page }) => { + await page.setIonViewport(); + + const breadcrumbs = page.locator('ion-breadcrumbs'); + + await page.click('#remove-btn'); + await page.waitForChanges(); + + await expect(breadcrumbs).toHaveScreenshot(screenshot(`breadcrumbs-reactive-remove-diff`)); + }); + }); + }); +}); diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-add-diff-md-ltr-Mobile-Safari-linux.png diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Chrome-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Chrome-linux.png rename to core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Chrome-linux.png diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Firefox-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Firefox-linux.png rename to core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Firefox-linux.png diff --git a/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Safari-linux.png similarity index 100% rename from core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e-legacy.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Safari-linux.png rename to core/src/components/breadcrumbs/test/reactive/breadcrumbs.e2e.ts-snapshots/breadcrumbs-reactive-remove-diff-md-ltr-Mobile-Safari-linux.png