From 62a3e115ef87cc418df7a93e059a5d1964c24620 Mon Sep 17 00:00:00 2001 From: Sean Perkins <13732623+sean-perkins@users.noreply.github.com> Date: Fri, 12 Apr 2024 16:18:15 -0400 Subject: [PATCH] chore(ci): stability for test-core-clean-build (#29338) Issue number: N/A --------- ## What is the current behavior? CI will fail randomly due to which stylesheet is processed last by rollup in Stencil. This leads to random failures. This is caused by some of the new ionic stylesheets not importing the same common stylesheet that included the CSS variable documentation. ## What is the new behavior? - Temporarily copies and pastes the documentation blocks to the affected ionic stylesheets - CI should no longer fail randomly when comparing the generated `api.txt` output - Adds a technical debt track to track removing these changes once the bug in Stencil is resolved and released ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- core/src/components/card/card.ionic.scss | 5 +++++ core/src/components/chip/chip.ionic.scss | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/core/src/components/card/card.ionic.scss b/core/src/components/card/card.ionic.scss index 0b14ff67d1..d77cf07306 100755 --- a/core/src/components/card/card.ionic.scss +++ b/core/src/components/card/card.ionic.scss @@ -5,6 +5,11 @@ // -------------------------------------------------- :host { + // TODO(FW-6178): Remove this once the Stencil bug is resolved. + /** + * @prop --background: Background of the card + * @prop --color: Color of the card + */ --background: #{tokens.$ionic-color-neutral-0}; --border-radius: #{tokens.$ionic-border-radius-rounded-small}; diff --git a/core/src/components/chip/chip.ionic.scss b/core/src/components/chip/chip.ionic.scss index 237d3de6b2..7200d73587 100644 --- a/core/src/components/chip/chip.ionic.scss +++ b/core/src/components/chip/chip.ionic.scss @@ -9,6 +9,11 @@ $ionic-states-focus-primary: #9ec4fd; $ionic-states-hover: #{rgba(#05080f, 0.16)}; // We should review how to make this in the future, as we are setting scss variables with a var() and fallback, and it doesn't work inside a rgba(). :host { + // TODO(FW-6178): Remove this once the Stencil bug is resolved. + /** + * @prop --background: Background of the chip + * @prop --color: Color of the chip + */ --background: #{tokens.$ionic-color-neutral-10}; --border-color: transparent; --border-radius: #{tokens.$ionic-border-radius-rounded-small};