From 6252458d49a48ce9c1b4c5ee7652148a8c2569cc Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 21 May 2019 13:16:07 -0400 Subject: [PATCH] test(components): add rtl tests and remove skips (#18319) references #17012 --- .../src/components/datetime/test/basic/e2e.ts | 4 +-- core/src/components/input/test/spec/e2e.ts | 14 ++++++++ .../components/item-sliding/test/basic/e2e.ts | 9 +++++ core/src/components/item/test/inputs/e2e.ts | 2 +- core/src/components/radio/test/basic/e2e.ts | 9 +++++ core/src/components/range/test/basic/e2e.ts | 9 +++++ .../components/searchbar/test/basic/e2e.ts | 34 +++++++++++++++++++ core/src/components/segment/test/basic/e2e.ts | 11 ++++++ core/src/components/segment/test/spec/e2e.ts | 11 ++++++ core/src/components/select/test/basic/e2e.ts | 15 +++++++- .../components/tab-bar/test/scenarios/e2e.ts | 9 +++++ core/src/components/toggle/test/basic/e2e.ts | 11 ++++++ core/src/components/toolbar/test/basic/e2e.ts | 11 +++++- .../src/components/toolbar/test/colors/e2e.ts | 2 +- .../components/toolbar/test/components/e2e.ts | 4 +-- .../components/toolbar/test/scenarios/e2e.ts | 11 +++++- core/src/components/toolbar/test/spec/e2e.ts | 2 +- .../components/toolbar/test/standalone/e2e.ts | 2 +- 18 files changed, 159 insertions(+), 11 deletions(-) diff --git a/core/src/components/datetime/test/basic/e2e.ts b/core/src/components/datetime/test/basic/e2e.ts index 1200711cb9..dc85a43cfa 100644 --- a/core/src/components/datetime/test/basic/e2e.ts +++ b/core/src/components/datetime/test/basic/e2e.ts @@ -1,6 +1,6 @@ import { newE2EPage } from '@stencil/core/testing'; -test.skip('datetime: basic', async () => { +test('datetime: basic', async () => { const page = await newE2EPage({ url: '/src/components/datetime/test/basic?ionic:_testing=true' }); @@ -19,7 +19,7 @@ test.skip('datetime: basic', async () => { expect(compare).toMatchScreenshot(); }); -test.skip('datetime: basic-rtl', async () => { +test('datetime: basic-rtl', async () => { const page = await newE2EPage({ url: '/src/components/datetime/test/basic?ionic:_testing=true&rtl=true' }); diff --git a/core/src/components/input/test/spec/e2e.ts b/core/src/components/input/test/spec/e2e.ts index 821bbbf4fe..cac6266925 100644 --- a/core/src/components/input/test/spec/e2e.ts +++ b/core/src/components/input/test/spec/e2e.ts @@ -13,3 +13,17 @@ test('input: spec', async () => { expect(compare).toMatchScreenshot(); } }); + +test('input:rtl: spec', async () => { + const page = await newE2EPage({ + url: '/src/components/input/test/spec?ionic:_testing=true&rtl=true' + }); + + const compares = []; + + compares.push(await page.compareScreenshot()); + + for (const compare of compares) { + expect(compare).toMatchScreenshot(); + } +}); diff --git a/core/src/components/item-sliding/test/basic/e2e.ts b/core/src/components/item-sliding/test/basic/e2e.ts index 6150103658..5950afbc67 100644 --- a/core/src/components/item-sliding/test/basic/e2e.ts +++ b/core/src/components/item-sliding/test/basic/e2e.ts @@ -8,3 +8,12 @@ test('item-sliding: basic', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('item-sliding:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/item-sliding/test/basic?ionic:_testing=true&rtl=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/item/test/inputs/e2e.ts b/core/src/components/item/test/inputs/e2e.ts index 9df4306889..0edef815a8 100644 --- a/core/src/components/item/test/inputs/e2e.ts +++ b/core/src/components/item/test/inputs/e2e.ts @@ -1,6 +1,6 @@ import { E2EPage, newE2EPage } from '@stencil/core/testing'; -test.skip('item: inputs', async () => { +test('item: inputs', async () => { const page = await newE2EPage({ url: '/src/components/item/test/inputs?ionic:_testing=true' }); diff --git a/core/src/components/radio/test/basic/e2e.ts b/core/src/components/radio/test/basic/e2e.ts index e6759e9086..e39de9d051 100644 --- a/core/src/components/radio/test/basic/e2e.ts +++ b/core/src/components/radio/test/basic/e2e.ts @@ -8,3 +8,12 @@ test('radio: basic', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('radio:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/radio/test/basic?ionic:_testing=true&rtl=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/range/test/basic/e2e.ts b/core/src/components/range/test/basic/e2e.ts index 896f02e7de..64b945abae 100644 --- a/core/src/components/range/test/basic/e2e.ts +++ b/core/src/components/range/test/basic/e2e.ts @@ -8,3 +8,12 @@ test('range: basic', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('range:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/range/test/basic?ionic:_testing=true&rtl=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/searchbar/test/basic/e2e.ts b/core/src/components/searchbar/test/basic/e2e.ts index bea469b781..f3df9585af 100644 --- a/core/src/components/searchbar/test/basic/e2e.ts +++ b/core/src/components/searchbar/test/basic/e2e.ts @@ -33,3 +33,37 @@ test('searchbar: basic', async () => { expect(compare).toMatchScreenshot(); } }); + +test('searchbar:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/searchbar/test/basic?ionic:_testing=true&rtl=true' + }); + + await page.waitFor(250); + + const compares = []; + compares.push(await page.compareScreenshot()); + + let searchbar = await page.find('#basic'); + await searchbar.callMethod('setFocus'); + + await page.waitFor(250); + searchbar = await page.find('#basic'); + expect(searchbar).toHaveClass('searchbar-has-focus'); + + compares.push(await page.compareScreenshot('focused')); + + // No Cancel Button Searchbar + searchbar = await page.find('#noCancel'); + await searchbar.callMethod('setFocus'); + + await page.waitFor(250); + searchbar = await page.find('#noCancel'); + expect(searchbar).toHaveClass('searchbar-has-focus'); + + compares.push(await page.compareScreenshot('no cancel button, focused')); + + for (const compare of compares) { + expect(compare).toMatchScreenshot(); + } +}); diff --git a/core/src/components/segment/test/basic/e2e.ts b/core/src/components/segment/test/basic/e2e.ts index 99a8d7d8fc..c026c7afb6 100644 --- a/core/src/components/segment/test/basic/e2e.ts +++ b/core/src/components/segment/test/basic/e2e.ts @@ -10,3 +10,14 @@ test('segment: basic', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('segment:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/segment/test/basic?ionic:_testing=true&rtl=true' + }); + + await page.waitFor(250); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/segment/test/spec/e2e.ts b/core/src/components/segment/test/spec/e2e.ts index 8362d25915..8dbdc13817 100644 --- a/core/src/components/segment/test/spec/e2e.ts +++ b/core/src/components/segment/test/spec/e2e.ts @@ -10,3 +10,14 @@ test('segment: spec', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('segment:rtl: spec', async () => { + const page = await newE2EPage({ + url: '/src/components/segment/test/spec?ionic:_testing=true&rtl=true' + }); + + await page.waitFor(250); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/select/test/basic/e2e.ts b/core/src/components/select/test/basic/e2e.ts index 6a06edc27d..ed56878479 100644 --- a/core/src/components/select/test/basic/e2e.ts +++ b/core/src/components/select/test/basic/e2e.ts @@ -1,6 +1,6 @@ import { newE2EPage } from '@stencil/core/testing'; -test.skip('select: basic', async () => { +test('select: basic', async () => { const page = await newE2EPage({ url: '/src/components/select/test/basic?ionic:_testing=true' }); @@ -70,3 +70,16 @@ test.skip('select: basic', async () => { expect(compare).toMatchScreenshot(); } }); + +test('select:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/select/test/basic?ionic:_testing=true&rtl=true' + }); + + const compares = []; + compares.push(await page.compareScreenshot()); + + for (const compare of compares) { + expect(compare).toMatchScreenshot(); + } +}); diff --git a/core/src/components/tab-bar/test/scenarios/e2e.ts b/core/src/components/tab-bar/test/scenarios/e2e.ts index f42ebf631c..f75a314a27 100644 --- a/core/src/components/tab-bar/test/scenarios/e2e.ts +++ b/core/src/components/tab-bar/test/scenarios/e2e.ts @@ -8,3 +8,12 @@ test('tab-bar: scenarios', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('tab-bar:rtl: scenarios', async () => { + const page = await newE2EPage({ + url: '/src/components/tab-bar/test/scenarios?ionic:_testing=true&rtl=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/toggle/test/basic/e2e.ts b/core/src/components/toggle/test/basic/e2e.ts index 78755ed8d3..6d84528458 100644 --- a/core/src/components/toggle/test/basic/e2e.ts +++ b/core/src/components/toggle/test/basic/e2e.ts @@ -10,3 +10,14 @@ test('toggle: basic', async () => { const compare = await page.compareScreenshot(); expect(compare).toMatchScreenshot(); }); + +test('toggle:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/toggle/test/basic?ionic:_testing=true&rtl=true' + }); + + await page.waitFor(250); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/toolbar/test/basic/e2e.ts b/core/src/components/toolbar/test/basic/e2e.ts index 5d935fa5aa..001c52d0e9 100644 --- a/core/src/components/toolbar/test/basic/e2e.ts +++ b/core/src/components/toolbar/test/basic/e2e.ts @@ -2,7 +2,16 @@ import { newE2EPage } from '@stencil/core/testing'; test('toolbar: basic', async () => { const page = await newE2EPage({ - url: '/src/components/toolbar/test/basic' + url: '/src/components/toolbar/test/basic?ionic:_testing=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); + +test('toolbar:rtl: basic', async () => { + const page = await newE2EPage({ + url: '/src/components/toolbar/test/basic?ionic:_testing=true&rtl=true' }); const compare = await page.compareScreenshot(); diff --git a/core/src/components/toolbar/test/colors/e2e.ts b/core/src/components/toolbar/test/colors/e2e.ts index 6a2c863cac..42408abf16 100644 --- a/core/src/components/toolbar/test/colors/e2e.ts +++ b/core/src/components/toolbar/test/colors/e2e.ts @@ -2,7 +2,7 @@ import { newE2EPage } from '@stencil/core/testing'; test('toolbar: colors', async () => { const page = await newE2EPage({ - url: '/src/components/toolbar/test/colors' + url: '/src/components/toolbar/test/colors?ionic:_testing=true' }); const compare = await page.compareScreenshot(); diff --git a/core/src/components/toolbar/test/components/e2e.ts b/core/src/components/toolbar/test/components/e2e.ts index aeba878304..1400f844f9 100644 --- a/core/src/components/toolbar/test/components/e2e.ts +++ b/core/src/components/toolbar/test/components/e2e.ts @@ -1,8 +1,8 @@ import { newE2EPage } from '@stencil/core/testing'; -test('toolbar: scenarios', async () => { +test('toolbar: components', async () => { const page = await newE2EPage({ - url: '/src/components/toolbar/test/scenarios' + url: '/src/components/toolbar/test/components?ionic:_testing=true' }); const compare = await page.compareScreenshot(); diff --git a/core/src/components/toolbar/test/scenarios/e2e.ts b/core/src/components/toolbar/test/scenarios/e2e.ts index aeba878304..4518653eae 100644 --- a/core/src/components/toolbar/test/scenarios/e2e.ts +++ b/core/src/components/toolbar/test/scenarios/e2e.ts @@ -2,7 +2,16 @@ import { newE2EPage } from '@stencil/core/testing'; test('toolbar: scenarios', async () => { const page = await newE2EPage({ - url: '/src/components/toolbar/test/scenarios' + url: '/src/components/toolbar/test/scenarios?ionic:_testing=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); + +test('toolbar:rtl: scenarios', async () => { + const page = await newE2EPage({ + url: '/src/components/toolbar/test/scenarios?ionic:_testing=true&rtl=true' }); const compare = await page.compareScreenshot(); diff --git a/core/src/components/toolbar/test/spec/e2e.ts b/core/src/components/toolbar/test/spec/e2e.ts index cc05144fea..bb6d4f55b0 100644 --- a/core/src/components/toolbar/test/spec/e2e.ts +++ b/core/src/components/toolbar/test/spec/e2e.ts @@ -2,7 +2,7 @@ import { newE2EPage } from '@stencil/core/testing'; test('toolbar: spec', async () => { const page = await newE2EPage({ - url: '/src/components/toolbar/test/spec' + url: '/src/components/toolbar/test/spec?ionic:_testing=true' }); const compare = await page.compareScreenshot(); diff --git a/core/src/components/toolbar/test/standalone/e2e.ts b/core/src/components/toolbar/test/standalone/e2e.ts index 8f7f0812fc..0f7adf5a68 100644 --- a/core/src/components/toolbar/test/standalone/e2e.ts +++ b/core/src/components/toolbar/test/standalone/e2e.ts @@ -2,7 +2,7 @@ import { newE2EPage } from '@stencil/core/testing'; test('toolbar: standalone', async () => { const page = await newE2EPage({ - url: '/src/components/toolbar/test/standalone' + url: '/src/components/toolbar/test/standalone?ionic:_testing=true' }); const compare = await page.compareScreenshot();