diff --git a/core/src/components/item/item.md.scss b/core/src/components/item/item.md.scss index d651db97de..3de4bcacf1 100644 --- a/core/src/components/item/item.md.scss +++ b/core/src/components/item/item.md.scss @@ -181,7 +181,7 @@ // -------------------------------------------------- ::slotted(ion-label) { - @include margin(13px, 0, 10px, 0); + @include margin($item-md-label-margin-top, $item-md-label-margin-end, $item-md-label-margin-bottom, $item-md-label-margin-start); } diff --git a/core/src/components/item/item.md.vars.scss b/core/src/components/item/item.md.vars.scss index eac923c016..21aea057a8 100644 --- a/core/src/components/item/item.md.vars.scss +++ b/core/src/components/item/item.md.vars.scss @@ -61,6 +61,22 @@ $item-md-input-highlight-color-valid: ion-color(success, base) !default; $item-md-input-highlight-color-invalid: ion-color(danger, base) !default; +// Item Label +// -------------------------------------------------- + +/// @prop - Margin top of the label +$item-md-label-margin-top: 11px !default; + +/// @prop - Margin end of the label +$item-md-label-margin-end: 0 !default; + +/// @prop - Margin bottom of the label +$item-md-label-margin-bottom: 10px !default; + +/// @prop - Margin start of the label +$item-md-label-margin-start: 0 !default; + + // Item Slots // -------------------------------------------------- diff --git a/core/src/components/label/label.md.vars.scss b/core/src/components/label/label.md.vars.scss index 3e40aa9247..1f3c7e18c6 100644 --- a/core/src/components/label/label.md.vars.scss +++ b/core/src/components/label/label.md.vars.scss @@ -10,18 +10,6 @@ $label-md-text-color: $text-color-step-600 !default; /// @prop - Text color of the stacked/floating label when it is focused $label-md-text-color-focused: ion-color(primary, base) !default; -/// @prop - Margin top of the label -$label-md-margin-top: 13px !default; - -/// @prop - Margin end of the label -$label-md-margin-end: 0 !default; - -/// @prop - Margin bottom of the label -$label-md-margin-bottom: 10px !default; - -/// @prop - Margin start of the label -$label-md-margin-start: 0 !default; - /// @prop - Line height of the label when the text wraps $label-md-text-wrap-line-height: 1.5 !default; diff --git a/core/src/components/list/test/icons/e2e.ts b/core/src/components/list/test/icons/e2e.ts new file mode 100644 index 0000000000..3e61af0299 --- /dev/null +++ b/core/src/components/list/test/icons/e2e.ts @@ -0,0 +1,10 @@ +import { newE2EPage } from '@stencil/core/testing'; + +test('list: icons', async () => { + const page = await newE2EPage({ + url: '/src/components/list/test/icons?ionic:_testing=true' + }); + + const compare = await page.compareScreenshot(); + expect(compare).toMatchScreenshot(); +}); diff --git a/core/src/components/list/test/icons/index.html b/core/src/components/list/test/icons/index.html new file mode 100644 index 0000000000..0e0308cc8c --- /dev/null +++ b/core/src/components/list/test/icons/index.html @@ -0,0 +1,108 @@ + + + + + + List - Icons + + + + + + + + + + + Topics + + + + + + + + + + + + + + + + Attractions + + + + + + Dining + + + + + + Education + + + + + + Health + + + + + + Family + + + + + + Office + + + + + + Promotions + + + + + + Radio + + + + + + Food + + + + + + Sports + + + + + + Travel + + + + + + + + + +