From 606d55c959d3afa8b6401850aa54dd1fb19741ff Mon Sep 17 00:00:00 2001
From: "Manu Mtz.-Almeida" <manu.mtza@gmail.com>
Date: Sat, 10 Feb 2018 00:00:41 +0100
Subject: [PATCH] fix(form): buttons

---
 packages/core/src/components/datetime/datetime.tsx           | 1 +
 packages/core/src/components/input/input.tsx                 | 1 +
 packages/core/src/components/item/item.tsx                   | 5 ++++-
 packages/core/src/components/searchbar/searchbar.tsx         | 2 ++
 .../core/src/components/segment-button/segment-button.tsx    | 4 ++++
 packages/core/src/components/select/select.tsx               | 1 +
 6 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/packages/core/src/components/datetime/datetime.tsx b/packages/core/src/components/datetime/datetime.tsx
index a43a64c8df..2d776dd1b6 100644
--- a/packages/core/src/components/datetime/datetime.tsx
+++ b/packages/core/src/components/datetime/datetime.tsx
@@ -619,6 +619,7 @@ export class Datetime {
     return [
       <div class={ datetimeTextClasses }>{ datetimeText }</div>,
       <button
+        type='button'
         aria-haspopup='true'
         id={this.datetimeId}
         aria-labelledby={this.labelId}
diff --git a/packages/core/src/components/input/input.tsx b/packages/core/src/components/input/input.tsx
index 055a8f6b94..e3b203a531 100644
--- a/packages/core/src/components/input/input.tsx
+++ b/packages/core/src/components/input/input.tsx
@@ -337,6 +337,7 @@ export class Input implements InputComponent {
         onKeyDown={this.inputKeydown.bind(this)}
       />,
       <button
+        type='button'
         hidden={this.clearInput !== true}
         class='input-clear-icon'
         onClick={this.clearTextInput.bind(this)}
diff --git a/packages/core/src/components/item/item.tsx b/packages/core/src/components/item/item.tsx
index 3a8fd8f6ec..913ef37443 100644
--- a/packages/core/src/components/item/item.tsx
+++ b/packages/core/src/components/item/item.tsx
@@ -105,9 +105,12 @@ export class Item {
     if (clickable) {
       TagType = this.href ? 'a' : 'button';
     }
+    const attrs = (TagType === 'button')
+      ? {type: 'button'}
+      : {};
 
     return (
-      <TagType class={themedClasses}>
+      <TagType class={themedClasses} {...attrs}>
         <slot name='start'></slot>
         <div class='item-inner'>
           <div class='input-wrapper'>
diff --git a/packages/core/src/components/searchbar/searchbar.tsx b/packages/core/src/components/searchbar/searchbar.tsx
index dd8f741f6e..6ef4ae0f90 100644
--- a/packages/core/src/components/searchbar/searchbar.tsx
+++ b/packages/core/src/components/searchbar/searchbar.tsx
@@ -324,6 +324,7 @@ export class Searchbar {
     const cancelButton =
       this.showCancelButton
         ? <button
+          type='button'
           tabindex={this.mode === 'ios' && !this.activated ? -1 : null}
           onClick={this.cancelSearchbar.bind(this)}
           onMouseDown={this.cancelSearchbar.bind(this)}
@@ -350,6 +351,7 @@ export class Searchbar {
           autoCorrect={this.autocorrect}
           spellCheck={this.spellcheck}/>
         <button
+          type='button'
           class='searchbar-clear-icon'
           onClick={this.clearInput.bind(this)}
           onMouseDown={this.clearInput.bind(this)}>
diff --git a/packages/core/src/components/segment-button/segment-button.tsx b/packages/core/src/components/segment-button/segment-button.tsx
index bdbe370294..e269b99a06 100644
--- a/packages/core/src/components/segment-button/segment-button.tsx
+++ b/packages/core/src/components/segment-button/segment-button.tsx
@@ -85,9 +85,13 @@ export class SegmentButton {
     };
 
     const TagType = this.href ? 'a' : 'button';
+    const attrs = (TagType === 'button')
+      ? {type: 'button'}
+      : {};
 
     return [
       <TagType
+       {...attrs}
         aria-pressed={this.activated}
         class={buttonClasses}
         disabled={this.disabled}
diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx
index ec9c924bc0..74a4f1506c 100644
--- a/packages/core/src/components/select/select.tsx
+++ b/packages/core/src/components/select/select.tsx
@@ -508,6 +508,7 @@ export class Select {
         <div class='select-icon-inner'></div>
       </div>,
       <button
+        type='button'
         role='combobox'
         aria-haspopup='dialog'
         aria-expanded={this.isExpanded}