From 5de31fb501b4e619d2a868ae5636b2dc03e64236 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Wed, 10 Feb 2016 11:54:46 -0600 Subject: [PATCH] test(modal): fix custom modal transition --- ionic/components/modal/test/basic/index.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ionic/components/modal/test/basic/index.ts b/ionic/components/modal/test/basic/index.ts index e975e48ebf..6fb0c07fb2 100644 --- a/ionic/components/modal/test/basic/index.ts +++ b/ionic/components/modal/test/basic/index.ts @@ -1,5 +1,5 @@ import {App, Page, Config, Platform} from 'ionic/ionic'; -import {Modal, ActionSheet, NavController, NavParams, Transition, ViewController} from 'ionic/ionic'; +import {Modal, ActionSheet, NavController, NavParams, Transition, TransitionOptions, ViewController} from 'ionic/ionic'; @Page({ @@ -285,9 +285,10 @@ class E2EApp { class FadeIn extends Transition { - constructor(enteringView: ViewController, leavingView: ViewController) { - super(enteringView.pageRef()); + constructor(enteringView: ViewController, leavingView: ViewController, opts: TransitionOptions) { + super(opts); this + .element(enteringView.pageRef()) .easing('ease') .duration(1000) .fromTo('translateY', '0%', '0%') @@ -298,9 +299,10 @@ class FadeIn extends Transition { Transition.register('my-fade-in', FadeIn); class FadeOut extends Transition { - constructor(enteringView: ViewController, leavingView: ViewController) { - super(leavingView.pageRef()); + constructor(enteringView: ViewController, leavingView: ViewController, opts: TransitionOptions) { + super(opts); this + .element(leavingView.pageRef()) .easing('ease') .duration(500) .fadeOut()