fix(content): tap-click deadlock (#17170)

fixes #17138
fixes #16863
fixes #16191
fixes #16911
This commit is contained in:
Manu MA
2019-01-18 18:53:35 +01:00
committed by GitHub
parent d513e8a952
commit 5cb7f68ee2
3 changed files with 40 additions and 22 deletions

View File

@@ -1,4 +1,4 @@
import { Component, ComponentInterface, Element, Event, EventEmitter, Method, Prop, QueueApi } from '@stencil/core';
import { Component, ComponentInterface, Element, Event, EventEmitter, Listen, Method, Prop, QueueApi } from '@stencil/core';
import { Color, Config, Mode, ScrollBaseDetail, ScrollDetail } from '../../interface';
import { isPlatform } from '../../utils/platform';
@@ -113,8 +113,14 @@ export class Content implements ComponentInterface {
}
componentDidUnload() {
if (this.watchDog) {
clearInterval(this.watchDog);
this.onScrollEnd();
}
@Listen('click', { capture: true })
onClick(ev: Event) {
if (this.isScrolling) {
ev.preventDefault();
ev.stopPropagation();
}
}
@@ -269,13 +275,14 @@ export class Content implements ComponentInterface {
}
private onScrollEnd() {
clearInterval(this.watchDog);
this.watchDog = null;
this.isScrolling = false;
this.ionScrollEnd.emit({
isScrolling: false
});
if (this.isScrolling) {
this.isScrolling = false;
this.ionScrollEnd.emit({
isScrolling: false
});
}
}
hostData() {

View File

@@ -37,6 +37,12 @@
--ion-background-color-rgb: 0,0,0;
--ion-text-color-rgb: 255,255,255;
}
[f] {
background: green;
width: 100px;
height: 100px;
}
</style>
<script>
class PageOne extends HTMLElement {
@@ -74,6 +80,15 @@
<ion-button class="next">Go to Page Three</ion-button>
</ion-nav-push>
</div>
<div f></div>
<div f></div>
<div f></div>
<div f></div>
<div f></div>
<div f></div>
<div f></div>
<div f></div>
</ion-content>
`;
}