javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(all): add optional generics typings for overlay component methods (#21393)

Browse Source
This commit is contained in:
Alexey Vinogradov
2020-06-03 20:08:27 +07:00
committed by GitHub
parent c7e94a1f23
commit 5bf83b80d7
16 changed files with 70 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/components/loading/loading.tsx
View File

@ -161,7 +161,7 @@ export class Loading implements ComponentInterface, OverlayInterface {
* Returns a promise that resolves when the loading did dismiss.
*/
@Method()
onDidDismiss(): Promise<OverlayEventDetail> {
onDidDismiss<T = any>(): Promise<OverlayEventDetail<T>> {
return eventMethod(this.el, 'ionLoadingDidDismiss');
}
@ -169,7 +169,7 @@ export class Loading implements ComponentInterface, OverlayInterface {
* Returns a promise that resolves when the loading will dismiss.
*/
@Method()
onWillDismiss(): Promise<OverlayEventDetail> {
onWillDismiss<T = any>(): Promise<OverlayEventDetail<T>> {
return eventMethod(this.el, 'ionLoadingWillDismiss');
}

8
core/src/components/loading/readme.md
View File

@ -307,23 +307,23 @@ Type: `Promise<boolean>`
### `onDidDismiss() => Promise<OverlayEventDetail<any>>`
### `onDidDismiss<T = any>() => Promise<OverlayEventDetail<T>>`
Returns a promise that resolves when the loading did dismiss.
#### Returns
Type: `Promise<OverlayEventDetail<any>>`
Type: `Promise<OverlayEventDetail<T>>`
### `onWillDismiss() => Promise<OverlayEventDetail<any>>`
### `onWillDismiss<T = any>() => Promise<OverlayEventDetail<T>>`
Returns a promise that resolves when the loading will dismiss.
#### Returns
Type: `Promise<OverlayEventDetail<any>>`
Type: `Promise<OverlayEventDetail<T>>`