javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 04:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(animation): add option to clean up old animation stylesheets (#20940)

Browse Source 
fixes #20610
This commit is contained in:
Liam DeBeasi
2020-04-03 09:28:41 -04:00
committed by GitHub
parent 4e28445ecb
commit 5b9840508f
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/utils/animation/animation-interface.ts
View File

@ -27,7 +27,7 @@ export interface Animation {
/** /**
* Destroy the animation and all child animations. * Destroy the animation and all child animations.
*/ */
destroy(): void; destroy(clearStyleSheets?: boolean): void;
progressStart(forceLinearEasing: boolean, step?: number): void; progressStart(forceLinearEasing: boolean, step?: number): void;
progressStep(step: number): void; progressStep(step: number): void;

15
core/src/utils/animation/animation.ts
View File

@ -1,5 +1,3 @@
// TODO: Add more tests. until then, be sure to manually test menu and swipe to go back/routing transitions
import { raf } from '../helpers'; import { raf } from '../helpers';
import { Animation, AnimationCallbackOptions, AnimationDirection, AnimationFill, AnimationKeyFrame, AnimationKeyFrameEdge, AnimationKeyFrames, AnimationLifecycle, AnimationPlayOptions } from './animation-interface'; import { Animation, AnimationCallbackOptions, AnimationDirection, AnimationFill, AnimationKeyFrame, AnimationKeyFrameEdge, AnimationKeyFrames, AnimationLifecycle, AnimationPlayOptions } from './animation-interface';
@ -72,12 +70,12 @@ export const createAnimation = (animationId?: string): Animation => {
return webAnimations; return webAnimations;
}; };
const destroy = () => { const destroy = (clearStyleSheets?: boolean) => {
childAnimations.forEach(childAnimation => { childAnimations.forEach(childAnimation => {
childAnimation.destroy(); childAnimation.destroy(clearStyleSheets);
}); });
cleanUp(); cleanUp(clearStyleSheets);
elements.length = 0; elements.length = 0;
childAnimations.length = 0; childAnimations.length = 0;
@ -97,9 +95,12 @@ export const createAnimation = (animationId?: string): Animation => {
* animation's elements, and removes the * animation's elements, and removes the
* animation's stylesheets from the DOM. * animation's stylesheets from the DOM.
*/ */
const cleanUp = () => { const cleanUp = (clearStyleSheets?: boolean) => {
cleanUpElements(); cleanUpElements();
cleanUpStyleSheets();
if (clearStyleSheets) {
cleanUpStyleSheets();
}
}; };
const resetFlags = () => { const resetFlags = () => {