javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-14 16:52:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): modal and popover components now correctly pass properties (#23761)

Browse Source 
resolves #23698
This commit is contained in:
Liam DeBeasi
2021-08-16 09:09:41 -04:00
committed by GitHub
parent 2995e337c8
commit 578b9062dd
7 changed files with 178 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/vue/scripts/copy-overlays.js
View File

@ -27,6 +27,14 @@ function generateOverlays() {
tag: 'ion-toast',
controller: 'toastController',
name: 'IonToast'
},
{
tag: 'ion-modal',
name: 'IonModal'
},
{
tag: 'ion-popover',
name: 'IonPopover'
}
]
@ -39,9 +47,15 @@ function generateOverlays() {
const props = getPropsFromDocsBlock(docsBlock);
componentImports.push(`import { ${component.name} as ${component.name}Cmp } from '@ionic/core/components/${component.tag}.js'`);
controllerImports.push(component.controller);
if (component.controller) {
controllerImports.push(component.controller);
}
const controllerParam = (component.controller) ? `, ${component.controller}` : '';
componentDefinitions.push(`
export const ${component.name} = /*@__PURE__*/ defineOverlayContainer<JSX.${component.name}>('${component.tag}', ${component.name}Cmp, [${props.join(', ')}], ${component.controller});
export const ${component.name} = /*@__PURE__*/ defineOverlayContainer<JSX.${component.name}>('${component.tag}', ${component.name}Cmp, [${props.join(', ')}]${controllerParam});
`);
});