From 52cd5d0ccedb8013c860198fc69f6bc0d4e6d386 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Mon, 8 Nov 2021 16:01:38 -0500 Subject: [PATCH] fix(input): ionInput event emits with type of InputEvent (#24111) The ionInput event for both ion-input and ion-textarea will emit with a type of InputEvent. --- angular/src/directives/proxies.ts | 4 ++-- core/api.txt | 4 ++-- core/src/components.d.ts | 4 ++-- core/src/components/input/input.tsx | 4 ++-- core/src/components/input/readme.md | 2 +- core/src/components/textarea/readme.md | 2 +- core/src/components/textarea/textarea.tsx | 4 ++-- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/angular/src/directives/proxies.ts b/angular/src/directives/proxies.ts index 3b060d6c9c..bd054eee3b 100644 --- a/angular/src/directives/proxies.ts +++ b/angular/src/directives/proxies.ts @@ -680,7 +680,7 @@ export declare interface IonInput extends Components.IonInput {} }) export class IonInput { /** Emitted when a keyboard input occurred. */ - ionInput!: EventEmitter>; + ionInput!: EventEmitter>; /** Emitted when the value has changed. */ ionChange!: EventEmitter>; /** Emitted when the input loses focus. */ @@ -1558,7 +1558,7 @@ export class IonTextarea { /** Emitted when the input value has changed. */ ionChange!: EventEmitter>; /** Emitted when a keyboard input occurred. */ - ionInput!: EventEmitter>; + ionInput!: EventEmitter>; /** Emitted when the input loses focus. */ ionBlur!: EventEmitter>; /** Emitted when the input has focus. */ diff --git a/core/api.txt b/core/api.txt index dd0de21130..453aa7a4e9 100644 --- a/core/api.txt +++ b/core/api.txt @@ -540,7 +540,7 @@ ion-input,method,setFocus,setFocus() => Promise ion-input,event,ionBlur,FocusEvent,true ion-input,event,ionChange,InputChangeEventDetail,true ion-input,event,ionFocus,FocusEvent,true -ion-input,event,ionInput,KeyboardEvent,true +ion-input,event,ionInput,InputEvent,true ion-input,css-prop,--background ion-input,css-prop,--color ion-input,css-prop,--padding-bottom @@ -1331,7 +1331,7 @@ ion-textarea,method,setFocus,setFocus() => Promise ion-textarea,event,ionBlur,FocusEvent,true ion-textarea,event,ionChange,TextareaChangeEventDetail,true ion-textarea,event,ionFocus,FocusEvent,true -ion-textarea,event,ionInput,KeyboardEvent,true +ion-textarea,event,ionInput,InputEvent,true ion-textarea,css-prop,--background ion-textarea,css-prop,--border-radius ion-textarea,css-prop,--color diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 49cd4308bf..7afe68c7b6 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -4791,7 +4791,7 @@ declare namespace LocalJSX { /** * Emitted when a keyboard input occurred. */ - "onIonInput"?: (event: CustomEvent) => void; + "onIonInput"?: (event: CustomEvent) => void; /** * Emitted when the styles change. */ @@ -6498,7 +6498,7 @@ declare namespace LocalJSX { /** * Emitted when a keyboard input occurred. */ - "onIonInput"?: (event: CustomEvent) => void; + "onIonInput"?: (event: CustomEvent) => void; /** * Emitted when the styles change. */ diff --git a/core/src/components/input/input.tsx b/core/src/components/input/input.tsx index 9b7a21737e..668349f06e 100644 --- a/core/src/components/input/input.tsx +++ b/core/src/components/input/input.tsx @@ -193,7 +193,7 @@ export class Input implements ComponentInterface { /** * Emitted when a keyboard input occurred. */ - @Event() ionInput!: EventEmitter; + @Event() ionInput!: EventEmitter; /** * Emitted when the value has changed. @@ -314,7 +314,7 @@ export class Input implements ComponentInterface { if (input) { this.value = input.value || ''; } - this.ionInput.emit(ev as KeyboardEvent); + this.ionInput.emit(ev as InputEvent); } private onBlur = (ev: FocusEvent) => { diff --git a/core/src/components/input/readme.md b/core/src/components/input/readme.md index 7a3c088643..414371ee77 100644 --- a/core/src/components/input/readme.md +++ b/core/src/components/input/readme.md @@ -357,7 +357,7 @@ export default defineComponent({ | `ionBlur` | Emitted when the input loses focus. | `CustomEvent` | | `ionChange` | Emitted when the value has changed. | `CustomEvent` | | `ionFocus` | Emitted when the input has focus. | `CustomEvent` | -| `ionInput` | Emitted when a keyboard input occurred. | `CustomEvent` | +| `ionInput` | Emitted when a keyboard input occurred. | `CustomEvent` | ## Methods diff --git a/core/src/components/textarea/readme.md b/core/src/components/textarea/readme.md index a7263700c4..27943cae2d 100644 --- a/core/src/components/textarea/readme.md +++ b/core/src/components/textarea/readme.md @@ -317,7 +317,7 @@ export default defineComponent({ | `ionBlur` | Emitted when the input loses focus. | `CustomEvent` | | `ionChange` | Emitted when the input value has changed. | `CustomEvent` | | `ionFocus` | Emitted when the input has focus. | `CustomEvent` | -| `ionInput` | Emitted when a keyboard input occurred. | `CustomEvent` | +| `ionInput` | Emitted when a keyboard input occurred. | `CustomEvent` | ## Methods diff --git a/core/src/components/textarea/textarea.tsx b/core/src/components/textarea/textarea.tsx index 55b0bcb18b..2c3d16b83e 100644 --- a/core/src/components/textarea/textarea.tsx +++ b/core/src/components/textarea/textarea.tsx @@ -177,7 +177,7 @@ export class Textarea implements ComponentInterface { /** * Emitted when a keyboard input occurred. */ - @Event() ionInput!: EventEmitter; + @Event() ionInput!: EventEmitter; /** * Emitted when the styles change. @@ -316,7 +316,7 @@ export class Textarea implements ComponentInterface { this.value = this.nativeInput.value; } this.emitStyle(); - this.ionInput.emit(ev as KeyboardEvent); + this.ionInput.emit(ev as InputEvent); } private onFocus = (ev: FocusEvent) => {