javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 05:58:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(status-tap): return promise from status tap for sake of testing, update lock file

Browse Source
This commit is contained in:
Dan Bucholtz
2018-02-01 16:10:28 -06:00
parent 665e7f36e0
commit 519ecddaf9
5 changed files with 213 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files

374
packages/core/package-lock.json generated
View File

File diff suppressed because it is too large Load Diff

2
packages/core/src/components.d.ts vendored
View File

@ -2829,7 +2829,7 @@ declare global {
} }
namespace JSXElements { namespace JSXElements {
export interface IonStatusTapAttributes extends HTMLAttributes { export interface IonStatusTapAttributes extends HTMLAttributes {
duration?: number;
} }
} }
} }

14
packages/core/src/components/status-tap/readme.md
View File

@ -5,6 +5,20 @@
<!-- Auto Generated Below --> <!-- Auto Generated Below -->
## Properties
#### duration
number
## Attributes
#### duration
number
## Methods ## Methods
#### mockTap() #### mockTap()

23
packages/core/src/components/status-tap/status-tap.tsx
View File

@ -1,6 +1,6 @@
import { Component, Listen, Method, Prop } from '@stencil/core'; import { Component, Listen, Method, Prop } from '@stencil/core';
import { DomController } from '../..'; import { DomController } from '../..';
import { domControllerAsync } from '../../utils/helpers';
@Component({ @Component({
tag: 'ion-status-tap' tag: 'ion-status-tap'
@ -13,28 +13,29 @@ export class StatusTap {
@Listen('window:statusTap') @Listen('window:statusTap')
statusTap() { statusTap() {
this.tap(); return this.tap();
} }
@Method() @Method()
mockTap() { mockTap() {
this.tap(); return this.tap();
} }
private tap() { private tap() {
this.dom.read(() => { return domControllerAsync(this.dom.read, () => {
const width = window.innerWidth; const width = window.innerWidth;
const height = window.innerWidth; const height = window.innerWidth;
const el = document.elementFromPoint(width / 2, height / 2); const el = document.elementFromPoint(width / 2, height / 2);
if (!el) { if (!el) {
return; return null;
}
const scroll = el.closest('ion-scroll') as HTMLIonScrollElement;
if (scroll) {
(scroll as any).componentOnReady().then(() => {
this.dom.write(() => scroll.scrollToTop(this.duration));
});
} }
return el.closest('ion-scroll');
}).then(([scroll]: HTMLIonScrollElement[]) => {
return (scroll as any).componentOnReady();
}).then((scroll: HTMLIonScrollElement) => {
return domControllerAsync(this.dom.write, () => {
return scroll.scrollToTop(this.duration);
});
}); });
} }
} }

56
packages/core/src/components/status-tap/test/basic/index.html Normal file
View File

@ -0,0 +1,56 @@
<!DOCTYPE html>
<html dir="ltr">
<head>
<meta charset="UTF-8">
<title>Status Tap - Basic</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no">
<script src="/dist/ionic.js"></script>
</head>
<body onload="init()">
<ion-app>
<ion-status-tap></ion-status-tap>
<ion-page>
<ion-header>
<ion-toolbar>
<ion-title>Status Tap - Basic</ion-title>
</ion-toolbar>
</ion-header>
<ion-content padding>
<div class="really-big">
<ion-button class="shawty-got-low">Mock Status Tap</ion-button>
</div>
</ion-content>
</ion-page>
</ion-app>
</body>
<script>
async function init() {
const button = document.querySelector('ion-button');
await button.componentOnReady();
button.addEventListener('click', async () => {
await doStatusTap();
});
}
async function doStatusTap() {
const statusTap = document.querySelector('ion-status-tap');
await statusTap.componentOnReady();
return await statusTap.mockTap();
}
</script>
<style>
.really-big {
height: 5000px;
background-color: blue;
}
.shawty-got-low {
margin-top: 4800px;
}
</style>