From 50dcab5c322ec509541a23aae605d5df6e6ec932 Mon Sep 17 00:00:00 2001
From: Ely Lucas <ely@meta-tek.net>
Date: Fri, 17 Jan 2020 16:23:26 -0700
Subject: [PATCH] fix(react): re attach props on update, fixes 20192 (#20228)

---
 .../react/src/components/createOverlayComponent.tsx  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/react/src/components/createOverlayComponent.tsx b/packages/react/src/components/createOverlayComponent.tsx
index d1d9ee5c17..170ad7e389 100644
--- a/packages/react/src/components/createOverlayComponent.tsx
+++ b/packages/react/src/components/createOverlayComponent.tsx
@@ -59,6 +59,10 @@ export const createOverlayComponent = <OverlayComponent extends object, OverlayT
     }
 
     async componentDidUpdate(prevProps: Props) {
+      if (this.overlay) {
+        attachProps(this.overlay, this.props, prevProps);
+      }
+
       if (prevProps.isOpen !== this.props.isOpen && this.props.isOpen === true) {
         this.present(prevProps);
       }
@@ -75,19 +79,19 @@ export const createOverlayComponent = <OverlayComponent extends object, OverlayT
         [dismissEventName]: this.handleDismiss
       };
 
-      const overlay = this.overlay = await controller.create({
+      this.overlay = await controller.create({
         ...elementProps,
         component: this.el,
         componentProps: {}
       });
 
       if (this.props.forwardedRef) {
-        (this.props.forwardedRef as any).current = overlay;
+        (this.props.forwardedRef as any).current = this.overlay;
       }
 
-      attachProps(overlay, elementProps, prevProps);
+      attachProps(this.overlay, elementProps, prevProps);
 
-      await overlay.present();
+      await this.overlay.present();
     }
 
     render() {