javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(all): add await to relevant assertions (#25527)

Browse Source
This commit is contained in:
Liam DeBeasi
2022-06-24 12:54:02 -04:00
committed by GitHub
parent d65e5a71b0
commit 50d806ee6f
33 changed files with 131 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
core/src/components/toggle/test/basic/toggle.e2e.ts
View File

@ -15,20 +15,20 @@ test.describe('toggle: basic', () => {
test('should have proper class and aria role when checked', async ({ page }) => {
const toggle = page.locator('#orange');
expect(toggle).not.toHaveClass(/toggle-checked/);
expect(toggle).toHaveAttribute('aria-checked', 'false');
await expect(toggle).not.toHaveClass(/toggle-checked/);
await expect(toggle).toHaveAttribute('aria-checked', 'false');
await toggle.click();
await page.waitForChanges();
expect(toggle).toHaveClass(/toggle-checked/);
expect(toggle).toHaveAttribute('aria-checked', 'true');
await expect(toggle).toHaveClass(/toggle-checked/);
await expect(toggle).toHaveAttribute('aria-checked', 'true');
await toggle.click();
await page.waitForChanges();
expect(toggle).not.toHaveClass(/toggle-checked/);
expect(toggle).toHaveAttribute('aria-checked', 'false');
await expect(toggle).not.toHaveClass(/toggle-checked/);
await expect(toggle).toHaveAttribute('aria-checked', 'false');
});
test('should fire change event with detail', async ({ page }) => {
@ -65,15 +65,15 @@ test.describe('toggle: basic', () => {
test('should pass properties down to hidden input', async ({ page }) => {
const toggle = page.locator('#grapeChecked');
expect(toggle).toBeDisabled();
expect(toggle).toHaveJSProperty('value', 'grape');
expect(toggle).toHaveJSProperty('name', 'grape');
await expect(toggle).toBeDisabled();
await expect(toggle).toHaveJSProperty('value', 'grape');
await expect(toggle).toHaveJSProperty('name', 'grape');
const hiddenInput = page.locator('#grapeChecked input[type=hidden]');
expect(hiddenInput).toBeDisabled();
expect(hiddenInput).toHaveJSProperty('value', 'grape');
expect(hiddenInput).toHaveJSProperty('name', 'grape');
await expect(hiddenInput).toBeDisabled();
await expect(hiddenInput).toHaveJSProperty('value', 'grape');
await expect(hiddenInput).toHaveJSProperty('name', 'grape');
await toggle.evaluate((el: HTMLIonToggleElement) => {
el.disabled = false;
@ -84,8 +84,8 @@ test.describe('toggle: basic', () => {
await page.waitForChanges();
expect(hiddenInput).not.toBeDisabled();
expect(hiddenInput).toHaveJSProperty('name', 'new-name');
await expect(hiddenInput).not.toBeDisabled();
await expect(hiddenInput).toHaveJSProperty('name', 'new-name');
// shouldn't have a value because it's unchecked
// note: using toHaveJSProperty to check empty string triggers error for some reason