javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(all): add await to relevant assertions (#25527)

Browse Source
This commit is contained in:
Liam DeBeasi
2022-06-24 12:54:02 -04:00
committed by GitHub
parent d65e5a71b0
commit 50d806ee6f
33 changed files with 131 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/components/loading/test/basic/loading.e2e.ts
View File

@ -24,7 +24,7 @@ test.describe('loading: basic', () => {
await ionLoadingDidDismiss.next();
expect(loading).toBeHidden();
await expect(loading).toBeHidden();
};
test('should open a basic loader', async ({ page }) => {
await runVisualTest(page, '#basic-loading', 'basic');
@ -54,7 +54,7 @@ test.describe('loading: basic', () => {
await ionLoadingDidPresent.next();
const loading = await page.locator('ion-loading');
expect(loading).toHaveAttribute('data-testid', 'basic-loading');
await expect(loading).toHaveAttribute('data-testid', 'basic-loading');
});
});
test.describe('loading: focus trapping', () => {
@ -73,13 +73,13 @@ test.describe('loading: basic', () => {
await page.keyboard.press('Tab');
expect(button).toBeFocused();
await expect(button).toBeFocused();
await page.keyboard.down('Shift');
await page.keyboard.press('Tab');
await page.keyboard.up('Shift');
expect(button).toBeFocused();
await expect(button).toBeFocused();
await page.keyboard.press('Tab');
@ -87,7 +87,7 @@ test.describe('loading: basic', () => {
await page.keyboard.up('Alt');
}
expect(button).toBeFocused();
await expect(button).toBeFocused();
});
});
});

2
core/src/components/loading/test/standalone/loading.e2e.ts
View File

@ -20,6 +20,6 @@ test.describe('loading: standalone', () => {
await ionLoadingDidDismiss.next();
expect(loading).toBeHidden();
await expect(loading).toBeHidden();
});
});