diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts new file mode 100644 index 0000000000..fa2681492f --- /dev/null +++ b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts @@ -0,0 +1,36 @@ +import { expect } from '@playwright/test'; +import { configs, test } from '@utils/test/playwright'; + +configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { + test.describe(title('reorder-group: font scaling'), () => { + test('should scale text on larger font sizes', async ({ page }) => { + await page.setContent( + ` + + + + Default Reorder + + + + + Custom Icon + + + + + + `, + config + ); + + const reorderGroup = page.locator('ion-reorder-group'); + + await expect(reorderGroup).toHaveScreenshot(screenshot(`reorder-group-scale`)); + }); + }); +}); diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..9552bb9c63 Binary files /dev/null and b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..b7dd55f462 Binary files /dev/null and b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Safari-linux.png b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..f89b863d12 Binary files /dev/null and b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Chrome-linux.png b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..2e9512ad72 Binary files /dev/null and b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Firefox-linux.png b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..47dcbbf125 Binary files /dev/null and b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Safari-linux.png b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..c10909f015 Binary files /dev/null and b/core/src/components/reorder-group/test/a11y/reorder-group.e2e.ts-snapshots/reorder-group-scale-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/reorder/reorder.ios.vars.scss b/core/src/components/reorder/reorder.ios.vars.scss index dd798ef68d..de6a0c757b 100644 --- a/core/src/components/reorder/reorder.ios.vars.scss +++ b/core/src/components/reorder/reorder.ios.vars.scss @@ -4,7 +4,7 @@ // -------------------------------------------------- /// @prop - Font size of the reorder icon -$reorder-ios-icon-font-size: 34px !default; +$reorder-ios-icon-font-size: 2.125rem !default; /// @prop - Opacity of the reorder icon $reorder-ios-icon-opacity: .4 !default; diff --git a/core/src/components/reorder/reorder.md.vars.scss b/core/src/components/reorder/reorder.md.vars.scss index 4cc47c86f0..add522168d 100644 --- a/core/src/components/reorder/reorder.md.vars.scss +++ b/core/src/components/reorder/reorder.md.vars.scss @@ -4,7 +4,7 @@ // -------------------------------------------------- /// @prop - Font size of the reorder icon -$reorder-md-icon-font-size: 31px !default; +$reorder-md-icon-font-size: 1.9375rem !default; /// @prop - Opacity of the reorder icon $reorder-md-icon-opacity: .3 !default; diff --git a/core/src/components/reorder/reorder.scss b/core/src/components/reorder/reorder.scss index 450a33b34d..a1b6c36845 100644 --- a/core/src/components/reorder/reorder.scss +++ b/core/src/components/reorder/reorder.scss @@ -17,6 +17,12 @@ .reorder-icon { display: block; - - font-size: 22px; +} + +/** + * This ensures that custom reorder + * icons resize with Dynamic Type. + */ +::slotted(ion-icon) { + font-size: 1rem; }