javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(refresher): find parent ion-content properly

Browse Source 
fixes #14833
This commit is contained in:
Manu Mtz.-Almeida
2018-07-24 00:42:14 +02:00
parent cb4acab198
commit 4eab209d18
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/src/components.d.ts vendored
View File

@ -3947,6 +3947,7 @@ declare global {
* If true, the menu is disabled. Default `false`. * If true, the menu is disabled. Default `false`.
*/ */
'disabled': boolean; 'disabled': boolean;
'getWidth': () => number;
'isActive': () => boolean; 'isActive': () => boolean;
'isOpen': () => boolean; 'isOpen': () => boolean;
/** /**

7
core/src/components/refresher/refresher.tsx
View File

@ -98,12 +98,7 @@ export class Refresher {
console.error('Make sure you use: <ion-refresher slot="fixed">'); console.error('Make sure you use: <ion-refresher slot="fixed">');
return; return;
} }
const parentElement = this.el.parentElement; const contentEl = this.el.closest('ion-content');
if (!parentElement) {
console.error('ion-refresher is not attached');
return;
}
const contentEl = parentElement.querySelector('ion-content');
if (contentEl) { if (contentEl) {
await contentEl.componentOnReady(); await contentEl.componentOnReady();
this.scrollEl = contentEl.getScrollElement(); this.scrollEl = contentEl.getScrollElement();