javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(menu-toggle): use ESM menuController (#19225)

Browse Source
This commit is contained in:
Manu MA
2019-08-29 15:19:01 +02:00
committed by GitHub
parent 9751f145e1
commit 4c30878fc7
5 changed files with 27 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/src/components/menu-button/menu-button.tsx
View File

@ -4,8 +4,9 @@ import { config } from '../../global/config';
import { getIonMode } from '../../global/ionic-global';
import { Color } from '../../interface';
import { ButtonInterface } from '../../utils/element-interface';
import { menuController } from '../../utils/menu-controller';
import { createColorClasses } from '../../utils/theme';
import { toggleMenu, updateVisibility } from '../menu-toggle/menu-toggle-util';
import { updateVisibility } from '../menu-toggle/menu-toggle-util';
@Component({
tag: 'ion-menu-button',
@ -46,22 +47,18 @@ export class MenuButton implements ComponentInterface, ButtonInterface {
*/
@Prop() type: 'submit' | 'reset' | 'button' = 'button';
async componentDidLoad() {
await this.setVisibility();
componentDidLoad() {
this.visibilityChanged();
}
@Listen('ionMenuChange', { target: 'body' })
@Listen('ionSplitPaneVisible', { target: 'body' })
async visibilityChanged() {
await this.setVisibility();
}
private setVisibility = async () => {
this.visible = await updateVisibility(this.menu);
}
private onClick = async () => {
await toggleMenu(this.menu);
return menuController.toggle(this.menu);
}
render() {
@ -93,7 +90,7 @@ export class MenuButton implements ComponentInterface, ButtonInterface {
>
<button
{...attrs}
disabled={this.disabled}
disabled={disabled}
class="button-native"
>
<slot>