javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(fab, fab-button): migrate to generators (#27308)

Browse Source 
Issue number: N/A

---------

<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

- Fab and fab button tests are using legacy syntax

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Fab and fab button tests use generator syntax

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
This commit is contained in:
Liam DeBeasi
2023-04-27 17:27:30 -04:00
committed by GitHub
parent 945624c0db
commit 4a25913669
41 changed files with 138 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/components/fab-button/test/a11y/fab-button.e2e-legacy.ts
View File

@ -1,16 +0,0 @@
import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright';
test.describe('fab-button: aria attributes', () => {
test('should inherit aria attributes to inner button', async ({ page, skip }) => {
skip.rtl();
skip.mode('ios');
await page.setContent(`
<ion-fab-button aria-label="Hello World">My Button</ion-fab-button>
`);
const nativeButton = page.locator('ion-fab-button button');
await expect(nativeButton).toHaveAttribute('aria-label', 'Hello World');
});
});

18
core/src/components/fab-button/test/a11y/fab-button.e2e.ts Normal file
View File

@ -0,0 +1,18 @@
import { expect } from '@playwright/test';
import { configs, test } from '@utils/test/playwright';
configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, config }) => {
test.describe(title('fab-button: aria attributes'), () => {
test('should inherit aria attributes to inner button', async ({ page }) => {
await page.setContent(
`
<ion-fab-button aria-label="Hello World">My Button</ion-fab-button>
`,
config
);
const nativeButton = page.locator('ion-fab-button button');
await expect(nativeButton).toHaveAttribute('aria-label', 'Hello World');
});
});
});