diff --git a/core/src/components/app/app.tsx b/core/src/components/app/app.tsx index 8f18362e08..21cb138138 100644 --- a/core/src/components/app/app.tsx +++ b/core/src/components/app/app.tsx @@ -12,6 +12,7 @@ import { Config } from '../../index'; } }) export class App { + mode: string; private isDevice = false; private deviceHacks = false; @@ -19,7 +20,6 @@ export class App { @Element() el: HTMLElement; @Prop({ context: 'config' }) config: Config; - mode: string; componentWillLoad() { this.isDevice = this.config.getBoolean('isDevice', false); @@ -39,9 +39,9 @@ export class App { render() { return [ - this.deviceHacks && , - , - this.isDevice && , + this.deviceHacks && , + , + this.isDevice && , ]; } diff --git a/core/src/components/app/readme.md b/core/src/components/app/readme.md index a5f662f426..6488e21641 100644 --- a/core/src/components/app/readme.md +++ b/core/src/components/app/readme.md @@ -1,6 +1,6 @@ # ion-app - +App is a container element for an Ionic application. There should only be one `` element per project. An app can have many Ionic components including menus, headers, content, and footers. The overlay components get appended to the `` when they are presented. diff --git a/core/src/utils/overlays.ts b/core/src/utils/overlays.ts index ec2e364baf..5c7ffd6680 100644 --- a/core/src/utils/overlays.ts +++ b/core/src/utils/overlays.ts @@ -13,12 +13,12 @@ export type Requires = { export function createOverlay, B> (element: T, opts: B): Promise { // convert the passed in overlay options into props - // that get passed down into the new alert + // that get passed down into the new overlay Object.assign(element, opts); element.overlayId = lastId++; - // append the alert element to the document body + // append the overlay element to the document body const appRoot = document.querySelector('ion-app') || document.body; appRoot.appendChild(element);