From 4928b996d69c6ceedb83ae61c7e25be98dfd8e4c Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Fri, 9 May 2014 09:33:31 -0500 Subject: [PATCH] set WP8 as a grade-b device --- js/utils/platform.js | 2 ++ scss/_platform.scss | 4 ++-- test/unit/angular/service/platform.unit.js | 8 ++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/js/utils/platform.js b/js/utils/platform.js index 9c7694124e..2ebf2781f8 100644 --- a/js/utils/platform.js +++ b/js/utils/platform.js @@ -116,6 +116,8 @@ if(this.isAndroid() && version < 4.4) { this.grade = (version < 4 ? 'c' : 'b'); + } else if(this.isWindowsPhone()) { + this.grade = 'b'; } } } diff --git a/scss/_platform.scss b/scss/_platform.scss index edd3c46ba2..d9db29a325 100644 --- a/scss/_platform.scss +++ b/scss/_platform.scss @@ -52,8 +52,8 @@ } } -.platform-android2:not(.enable-transitions) * { - // disable transitions on Android 2 +.platform-c:not(.enable-transitions) * { + // disable transitions on grade-c devices (Android 2) -webkit-transition: none !important; transition: none !important; } diff --git a/test/unit/angular/service/platform.unit.js b/test/unit/angular/service/platform.unit.js index 98af3b0c19..f35499fa08 100644 --- a/test/unit/angular/service/platform.unit.js +++ b/test/unit/angular/service/platform.unit.js @@ -276,6 +276,14 @@ describe('Ionic Platform Service', function() { expect(ionic.Platform.grade).toEqual('a'); }); + it('sets grade b from Windows Phone platform', function() { + window.cordova = {}; + ionic.Platform.setPlatform('windowsphone'); + ionic.Platform.setVersion('8.0'); + ionic.Platform._checkPlatforms(); + expect(ionic.Platform.grade).toEqual('b'); + }); + it('sets grade a from unknown platform', function() { window.cordova = {}; ionic.Platform.setPlatform('whatever');