javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: sync with feature-8.0

Browse Source
This commit is contained in:
Liam DeBeasi
2024-02-06 12:50:45 -05:00
parent b2481bfd7f 9856295915
commit 47915c3164
7 changed files with 41 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/components/refresher-content/refresher-content.tsx
View File

@ -114,7 +114,7 @@ export class RefresherContent implements ComponentInterface {
{this.pullingIcon && hasSpinner && (
<div class="refresher-pulling-icon">
<div class="spinner-arrow-container">
<ion-spinner name={this.pullingIcon as SpinnerTypes} aria-label="pulling icon" paused></ion-spinner>
<ion-spinner name={this.pullingIcon as SpinnerTypes} paused></ion-spinner>
{mode === 'md' && this.pullingIcon === 'circular' && (
<div class="arrow-container">
<ion-icon icon={caretBackSharp} aria-hidden="true"></ion-icon>
@ -133,7 +133,7 @@ export class RefresherContent implements ComponentInterface {
<div class="refresher-refreshing">
{this.refreshingSpinner && (
<div class="refresher-refreshing-icon">
<ion-spinner name={this.refreshingSpinner} aria-label="refreshing icon"></ion-spinner>
<ion-spinner name={this.refreshingSpinner}></ion-spinner>
</div>
)}
{this.refreshingText !== undefined && this.renderRefreshingText()}

3
core/src/components/refresher/test/a11y/refresher.e2e.ts
View File

@ -23,7 +23,8 @@ configs({ directions: ['ltr'], modes: ['md'], themes: ['light', 'dark'] }).forEa
await expect(refresher).toHaveClass(/refresher-pulling/);
const results = await new AxeBuilder({ page }).analyze();
// TODO(FW-5937): Remove the disableRules once the ticket is resolved.
const results = await new AxeBuilder({ page }).disableRules('aria-progressbar-name').analyze();
expect(results.violations).toEqual([]);
});

6
core/src/components/toast/toast-interface.ts
View File

@ -27,18 +27,12 @@ export interface ToastOptions {
export type ToastLayout = 'baseline' | 'stacked';
// TODO FW-4923 remove cssClass property
export interface ToastButton {
text?: string;
icon?: string;
side?: 'start' | 'end';
role?: 'cancel' | string;
/**
* @deprecated Use the toast button's CSS Shadow Parts instead.
*/
cssClass?: string | string[];
htmlAttributes?: { [key: string]: any };
handler?: () => boolean | void | Promise<boolean | void>;
}

1
core/src/components/toast/toast.tsx
View File

@ -778,7 +778,6 @@ const buttonClass = (button: ToastButton): CssClassMap => {
[`toast-button-${button.role}`]: button.role !== undefined,
'ion-focusable': true,
'ion-activatable': true,
...getClassMap(button.cssClass),
};
};