diff --git a/packages/core/src/components/range/range-knob.tsx b/packages/core/src/components/range/range-knob.tsx
index 1913441ec2..52849f5ccf 100644
--- a/packages/core/src/components/range/range-knob.tsx
+++ b/packages/core/src/components/range/range-knob.tsx
@@ -60,11 +60,11 @@ export class RangeKnob {
render() {
if (this.pin) {
return [
-
{this.val}
,
-
+ {this.val}
,
+
];
}
- return ;
+ return ;
}
}
diff --git a/packages/core/src/components/range/range.tsx b/packages/core/src/components/range/range.tsx
index ae35d6c9c6..d04b38db63 100644
--- a/packages/core/src/components/range/range.tsx
+++ b/packages/core/src/components/range/range.tsx
@@ -45,8 +45,7 @@ export class Range implements BaseInputComponent {
@Prop() color: string;
@Prop() mode: string;
- @Prop({ state: true })
- value: any;
+ @Prop({ mutable: true }) value: any;
@Prop() disabled: boolean = false;
@Prop() min: number = 0;
@@ -225,14 +224,9 @@ export class Range implements BaseInputComponent {
upper: Math.max(this._valA, this._valB)
};
- console.debug(
- `range, updateKnob: ${ratio}, lower: ${this.value.lower}, upper: ${this
- .value.upper}`
- );
} else {
// single knob only has one value
value = this._valA;
- console.debug(`range, updateKnob: ${ratio}, value: ${this.value}`);
}
// Update input value
@@ -280,17 +274,13 @@ export class Range implements BaseInputComponent {
this.updateBar();
}
- canStart() {
- const el = this.rangeEl.querySelector('.range-slider');
- this._rect = el.getBoundingClientRect();
- return !this.disabled;
- }
-
- onDown(detail: GestureDetail) {
+ onDragStart(detail: GestureDetail) {
if (this.disabled) return false;
this.fireFocus();
const current = { x: detail.currentX, y: detail.currentY };
+ const el = this.rangeEl.querySelector('.range-slider');
+ this._rect = el.getBoundingClientRect();
const rect = this._rect;
// figure out which knob they started closer to
@@ -307,7 +297,7 @@ export class Range implements BaseInputComponent {
return true;
}
- onUp(detail: GestureDetail) {
+ onDragEnd(detail: GestureDetail) {
if (this.disabled) {
return;
}
@@ -339,43 +329,43 @@ export class Range implements BaseInputComponent {
render() {
return [
- ,
+ ,
-
+
{this._ticks.map(t =>
)}
-
+
,
-
+
];
}
}