javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(datetime): datetime no longer reports having a value if none is set (#18541)

Browse Source 
fixes #17979 
fixes #18540
This commit is contained in:
Kelvin Dart
2019-06-27 15:48:09 +01:00
committed by Liam DeBeasi
parent 22ac160021
commit 45b82dc466
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/components/datetime/datetime.tsx
View File

@ -565,8 +565,7 @@ export class Datetime implements ComponentInterface {
} }
private hasValue(): boolean { private hasValue(): boolean {
const val = this.datetimeValue; return this.text !== undefined;
return Object.keys(val).length > 0;
} }
private setFocus() { private setFocus() {

10
core/src/components/datetime/test/basic/index.html
View File

@ -31,6 +31,16 @@
<ion-label>Default</ion-label> <ion-label>Default</ion-label>
<ion-datetime></ion-datetime> <ion-datetime></ion-datetime>
</ion-item> </ion-item>
<ion-item>
<ion-label position="floating">Default with floating label</ion-label>
<ion-datetime></ion-datetime>
</ion-item>
<ion-item>
<ion-label position="floating">Placeholder with floating label</ion-label>
<ion-datetime placeholder="Select a date"></ion-datetime>
</ion-item>
<ion-item> <ion-item>
<ion-label>Max</ion-label> <ion-label>Max</ion-label>