javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor($ionicTabsDelegate): for .select() take away second argument

Browse Source 
Closes #1682
This commit is contained in:
Andrew
2014-08-20 10:02:45 -06:00
parent 2a5595d11e
commit 4595fd3cc4
4 changed files with 9 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/unit/angular/directive/tabs.unit.js
View File

@@ -100,33 +100,6 @@ describe('tabs', function() {
expect(ctrl.selectedTab()).toBe('foo');
});
it('.select should throw error if tab doesnt exist', function() {
var tab = {};
ctrl.add(tab);
expect(function() {
ctrl.select({});
}).toThrow();
expect(function() {
ctrl.select(null);
}).toThrow();
expect(function() {
ctrl.select(tab);
}).not.toThrow();
});
it('.select should throw error if number is bad', function() {
ctrl.add({});
expect(function() {
ctrl.select(1);
}).toThrow();
expect(function() {
ctrl.select(-1);
}).toThrow();
expect(function() {
ctrl.select(0);
}).not.toThrow();
});
it('.select should allow number', function() {
var tab1 = {}, tab2 = {};
ctrl.add(tab1);
@@ -513,7 +486,7 @@ describe('tabs', function() {
tabEl.scope().$broadcast('$stateChangeSuccess');
expect(tabMatchesState).toHaveBeenCalled();
expect(tabsCtrl.select).toHaveBeenCalledWith(tabEl.scope());
expect(tabsCtrl.select).toHaveBeenCalledWith(tabEl.scope(), false);
});
it('should transclude on $tabSelected=true', function() {