javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-21 04:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(menu, split-pane): ssr does not fail on null customElements check (#26854)

Browse Source 
resolves #24714
This commit is contained in:
Liam DeBeasi
2023-03-02 10:05:15 -05:00
committed by GitHub
parent f54fc18884
commit 451d2204e7
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/components/menu/menu.tsx
View File

@ -173,7 +173,7 @@ export class Menu implements ComponentInterface, MenuI {
async connectedCallback() { async connectedCallback() {
// TODO: connectedCallback is fired in CE build // TODO: connectedCallback is fired in CE build
// before WC is defined. This needs to be fixed in Stencil. // before WC is defined. This needs to be fixed in Stencil.
if (typeof (customElements as any) !== 'undefined') { if (typeof (customElements as any) !== 'undefined' && (customElements as any) != null) {
await customElements.whenDefined('ion-menu'); await customElements.whenDefined('ion-menu');
} }

2
core/src/components/split-pane/split-pane.tsx
View File

@ -65,7 +65,7 @@ export class SplitPane implements ComponentInterface {
async connectedCallback() { async connectedCallback() {
// TODO: connectedCallback is fired in CE build // TODO: connectedCallback is fired in CE build
// before WC is defined. This needs to be fixed in Stencil. // before WC is defined. This needs to be fixed in Stencil.
if (typeof (customElements as any) !== 'undefined') { if (typeof (customElements as any) !== 'undefined' && (customElements as any) != null) {
await customElements.whenDefined('ion-split-pane'); await customElements.whenDefined('ion-split-pane');
} }
this.styleChildren(); this.styleChildren();