javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(segment): only call updateSegmentView when gesture ends or button is clicked

Browse Source
This commit is contained in:
Brandy Carney
2024-09-23 14:29:03 -04:00
parent 678990d77a
commit 44e8374791
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/components/segment/segment.tsx
View File

@ -202,6 +202,7 @@ export class Segment implements ComponentInterface {
if (value !== undefined) {
if (this.valueBeforeGesture !== value) {
this.emitValueChange();
this.updateSegmentView();
}
}
this.valueBeforeGesture = undefined;
@ -234,11 +235,7 @@ export class Segment implements ComponentInterface {
const buttons = this.getButtons();
buttons.forEach((button) => {
if (activated) {
button.classList.add('segment-button-activated');
} else {
button.classList.remove('segment-button-activated');
}
button.classList.toggle('segment-button-activated', activated);
});
this.activated = activated;
}
@ -307,7 +304,6 @@ export class Segment implements ComponentInterface {
this.value = current.value;
this.setCheckedClasses();
this.updateSegmentView();
}
private setCheckedClasses() {
@ -323,6 +319,13 @@ export class Segment implements ComponentInterface {
}
}
/**
* Finds the related segment view and sets its current content
* based on the selected segment button. This method
* should be called only after the gesture is completed
* (if dragging between segments) or when a segment button
* is clicked directly.
*/
private updateSegmentView() {
const buttons = this.getButtons();
const button = buttons.find((btn) => btn.value === this.value);
@ -505,6 +508,7 @@ export class Segment implements ComponentInterface {
if (current !== previous) {
this.emitValueChange();
this.updateSegmentView();
}
if (this.scrollable || !this.swipeGesture) {