From 441a21c4949827a52d1a6edff58f1cb786744acb Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Mon, 31 Mar 2014 11:04:23 -0500 Subject: [PATCH] fix(popup): Backwards compatible remove popup from DOM, closes #851 --- js/ext/angular/src/service/ionicPopup.js | 2 +- js/ext/angular/test/popup.html | 37 +++++++++++++++++++++++- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/js/ext/angular/src/service/ionicPopup.js b/js/ext/angular/src/service/ionicPopup.js index a708f71603..6109e6a6d9 100644 --- a/js/ext/angular/src/service/ionicPopup.js +++ b/js/ext/angular/src/service/ionicPopup.js @@ -184,7 +184,7 @@ angular.module('ionic.service.popup', ['ionic.service.templateLoad']) popup.el.classList.add('popup-hidden'); $timeout(function() { - popup.el.remove(); + popup.el.parentNode.removeChild(popup.el); }, 400); }; diff --git a/js/ext/angular/test/popup.html b/js/ext/angular/test/popup.html index 0467f3290b..caac135a62 100644 --- a/js/ext/angular/test/popup.html +++ b/js/ext/angular/test/popup.html @@ -17,7 +17,42 @@ -
+
+ Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item + Item +