refactor(angular): lazy loading tabs (#16637)

Fixes #16619
This commit is contained in:
Manu MA
2018-12-08 17:23:39 +01:00
committed by GitHub
parent 86fc9a557e
commit 437ad09122
34 changed files with 11361 additions and 246 deletions

View File

@@ -84,9 +84,8 @@ export class BackButton implements ComponentInterface {
<span class="button-inner">
{backButtonIcon && <ion-icon icon={backButtonIcon} lazy={false}></ion-icon>}
{backButtonText && <span class="button-text">{backButtonText}</span>}
{this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
</span>
{this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
{this.mode === 'md' && <ion-ripple-effect type="unbounded"></ion-ripple-effect>}
</button>
);
}

View File

@@ -54,7 +54,7 @@ export class MenuButton implements ComponentInterface {
<slot>
<ion-icon icon={menuIcon} mode={this.mode} color={this.color} lazy={false} />
</slot>
{this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
{this.mode === 'md' && <ion-ripple-effect type="unbounded"></ion-ripple-effect>}
</button>
</ion-menu-toggle>
);

View File

@@ -72,9 +72,6 @@ export function iosEnterAnimation(AnimationC: Animation, baseEl: HTMLElement, ev
// make it pop up if there's room above
if (targetTop + targetHeight + contentHeight > bodyHeight && targetTop - contentHeight > 0) {
arrowCSS.top = targetTop - (arrowHeight + 1);
console.log(arrowCSS);
console.log(targetTop);
console.log(contentHeight);
popoverCSS.top = targetTop - contentHeight - (arrowHeight - 1);
baseEl.className = baseEl.className + ' popover-bottom';

View File

@@ -175,8 +175,6 @@ export class Refresher implements ComponentInterface {
}
private onStart() {
console.log('start');
this.progress = 0;
this.state = RefresherState.Inactive;
}

View File

@@ -16,6 +16,10 @@
width: auto;
padding-bottom: var(--ion-safe-area-bottom, 0);
border-top: var(--border);
background: var(--background);
color: var(--color);
@@ -41,15 +45,12 @@
}
:host([slot="top"]) {
padding-bottom: 0;
border-top: 0;
border-bottom: var(--border);
}
:host([slot="bottom"]) {
padding-bottom: var(--ion-safe-area-bottom, 0);
border-top: var(--border);
}
:host(.tabbar-hidden) {
/* stylelint-disable-next-line declaration-no-important */
display: none !important;