refactor(item): remove no-lines attribute in favor of lines property (#14407)

* docs(components): update grammar and docs

* docs(item): update item documentation and add usage

* test(item): add lines test

* feat(list): add lines property to override borders on items

* feat(item): add lines property to override borders on items

* refactor(item): remove old uses of no-lines attribute

* fix(item-sliding): update item options to show border

- show the border on left options only if in a full list
- show the border on both options only if in an inset list (or ios by
default)
- don’t show border on either for no lines list (and md by default)

also renames isRightSide to isEndSide to match the side values

* chore(package): update package lock

* style(item): fix lint errors

* test(item): update item tests

* refactor(item): remove the custom styling of last child items

instead of us overriding first/last child items to have borders we are
going to add to the documentation how to style items with a full border

* fix(item): apply border to item inputs for MD mode

* docs(components): update docs based on new build

* docs(usage): update item usage to show lines being used

* fix(item): do not set the padding right to 0 on an item by default

* fix(item): cast lines to boolean

fixes: #5537 #13218 #12689 #12073 #9112
This commit is contained in:
Brandy Carney
2018-05-07 17:16:11 -04:00
committed by GitHub
parent 69cb2e2334
commit 427222cc29
43 changed files with 11821 additions and 171 deletions

View File

@@ -11,7 +11,7 @@ const BOX_SHADOW_WIDTH = 8;
export default function(Animation: Animation, _: HTMLElement, menu: Menu): Promise<Animation> {
let closedX: string, openedX: string;
const width = menu.width + BOX_SHADOW_WIDTH;
if (menu.isRightSide) {
if (menu.isEndSide) {
// right side
closedX = width + 'px';
openedX = '0px';

View File

@@ -12,7 +12,7 @@ export default function(Animation: Animation, _: HTMLElement, menu: Menu): Promi
let contentOpenedX: string, menuClosedX: string;
const width = menu.width;
if (menu.isRightSide) {
if (menu.isEndSide) {
contentOpenedX = -width + 'px';
menuClosedX = width + 'px';

View File

@@ -8,7 +8,7 @@ import baseAnimation from './base';
* The menu itself, which is under the content, does not move.
*/
export default function(Animation: Animation, _: HTMLElement, menu: Menu): Promise<Animation> {
const openedX = (menu.width * (menu.isRightSide ? -1 : 1)) + 'px';
const openedX = (menu.width * (menu.isEndSide ? -1 : 1)) + 'px';
const contentOpen = new Animation()
.addElement(menu.contentEl)