javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 21:48:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

style(navigation): fixed sass-lint error, changed function name

Browse Source 
fixed sass-lint error, changed function name
This commit is contained in:
Dan Bucholtz
2016-06-14 22:27:31 -05:00
parent efcdd20508
commit 41ecfdc4ae
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/nav/nav-controller.ts
View File

@ -1171,7 +1171,7 @@ export class NavController extends Ion {
ev: opts.ev, ev: opts.ev,
}; };
let transAnimation = this.createTransitionWrapper(enteringView, leavingView, transitionOpts); let transAnimation = this._createTrans(enteringView, leavingView, transitionOpts);
this._trans && this._trans.destroy(); this._trans && this._trans.destroy();
this._trans = transAnimation; this._trans = transAnimation;
@ -1394,7 +1394,7 @@ export class NavController extends Ion {
* to make it easy/possible to mock the method call by overriding the function. * to make it easy/possible to mock the method call by overriding the function.
* In testing we don't want to actually do the animation, we want to return a stub instead * In testing we don't want to actually do the animation, we want to return a stub instead
*/ */
private createTransitionWrapper(enteringView: ViewController, leavingView: ViewController, transitionOpts: any) { private _createTrans(enteringView: ViewController, leavingView: ViewController, transitionOpts: any) {
return Transition.createTransition(enteringView, leavingView, transitionOpts); return Transition.createTransition(enteringView, leavingView, transitionOpts);
} }

8
src/components/nav/test/nav-controller.spec.ts
View File

@ -1378,7 +1378,7 @@ export function run() {
getDuration: () => { return 50}, getDuration: () => { return 50},
onFinish: () => {} onFinish: () => {}
}; };
nav.createTransitionWrapper = () => { nav._createTrans = () => {
return mockTransition; return mockTransition;
}; };
nav.config = { nav.config = {
@ -1415,7 +1415,7 @@ export function run() {
getDuration: () => { return 200}, getDuration: () => { return 200},
onFinish: () => {} onFinish: () => {}
}; };
nav.createTransitionWrapper = () => { nav._createTrans = () => {
return mockTransition; return mockTransition;
}; };
nav.config = { nav.config = {
@ -1455,7 +1455,7 @@ export function run() {
getDuration: () => { return 200}, getDuration: () => { return 200},
onFinish: () => {} onFinish: () => {}
}; };
nav.createTransitionWrapper = () => { nav._createTrans = () => {
return mockTransition; return mockTransition;
}; };
nav.config = { nav.config = {
@ -1495,7 +1495,7 @@ export function run() {
getDuration: () => { return 200}, getDuration: () => { return 200},
onFinish: () => {} onFinish: () => {}
}; };
nav.createTransitionWrapper = () => { nav._createTrans = () => {
return mockTransition; return mockTransition;
}; };
nav.config = { nav.config = {