javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(datetime): selecting time now works correctly on firefox (#23583)

Browse Source 
resolves #23545
This commit is contained in:
Liam DeBeasi
2021-07-06 14:27:27 -04:00
committed by GitHub
parent 8f172de355
commit 4188964dc8
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/components/datetime/datetime.tsx
View File

@ -1009,7 +1009,15 @@ export class Datetime implements ComponentInterface {
otherCol.classList.remove('time-column-active');
const bbox = activeCol.getBoundingClientRect();
const activeElement = this.el!.shadowRoot!.elementFromPoint(bbox.x + 1, bbox.y + 1)!;
/**
* Do not use floating point
* here as some browsers may clamp
* or round down.
*/
const x = Math.ceil(bbox.x + 1);
const y = Math.ceil(bbox.y + 1);
const activeElement = this.el!.shadowRoot!.elementFromPoint(x, y)!;
const value = parseInt(activeElement.getAttribute('data-value')!, 10);
if (colType === 'hour') {