diff --git a/angular/src/directives/proxies.ts b/angular/src/directives/proxies.ts index 0c3e5c333a..529ac88d23 100644 --- a/angular/src/directives/proxies.ts +++ b/angular/src/directives/proxies.ts @@ -1568,10 +1568,6 @@ export declare interface IonSelect extends Components.IonSelect { * Emitted when the selection is cancelled. */ ionCancel: EventEmitter>; - /** - * Emitted when the overlay is dismissed. - */ - ionDismiss: EventEmitter>; /** * Emitted when the select has focus. */ @@ -1599,7 +1595,7 @@ export class IonSelect { constructor(c: ChangeDetectorRef, r: ElementRef, protected z: NgZone) { c.detach(); this.el = r.nativeElement; - proxyOutputs(this, this.el, ["ionChange", "ionCancel", "ionDismiss", "ionFocus", "ionBlur"]); + proxyOutputs(this, this.el, ['ionChange', 'ionCancel', 'ionFocus', 'ionBlur']); } } diff --git a/core/api.txt b/core/api.txt index fdc7412069..ce9578268f 100644 --- a/core/api.txt +++ b/core/api.txt @@ -1172,7 +1172,6 @@ ion-select,method,open,open(event?: UIEvent | undefined) => Promise ion-select,event,ionBlur,void,true ion-select,event,ionCancel,void,true ion-select,event,ionChange,SelectChangeEventDetail,true -ion-select,event,ionDismiss,void,true ion-select,event,ionFocus,void,true ion-select,css-prop,--padding-bottom ion-select,css-prop,--padding-end diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 6eeaab4812..fa3c05f3e6 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -6147,10 +6147,6 @@ declare namespace LocalJSX { * Emitted when the value has changed. */ "onIonChange"?: (event: CustomEvent) => void; - /** - * Emitted when the overlay is dismissed. - */ - "onIonDismiss"?: (event: CustomEvent) => void; /** * Emitted when the select has focus. */ diff --git a/core/src/components/select/readme.md b/core/src/components/select/readme.md index 4aa7ebd3d1..03f7259eb9 100644 --- a/core/src/components/select/readme.md +++ b/core/src/components/select/readme.md @@ -1385,13 +1385,12 @@ export default defineComponent({ ## Events -| Event | Description | Type | -| ------------ | ---------------------------------------- | ------------------------------------------- | -| `ionBlur` | Emitted when the select loses focus. | `CustomEvent` | -| `ionCancel` | Emitted when the selection is cancelled. | `CustomEvent` | -| `ionChange` | Emitted when the value has changed. | `CustomEvent>` | -| `ionDismiss` | Emitted when the overlay is dismissed. | `CustomEvent` | -| `ionFocus` | Emitted when the select has focus. | `CustomEvent` | +| Event | Description | Type | +| ----------- | ---------------------------------------- | ------------------------------------------- | +| `ionBlur` | Emitted when the select loses focus. | `CustomEvent` | +| `ionCancel` | Emitted when the selection is cancelled. | `CustomEvent` | +| `ionChange` | Emitted when the value has changed. | `CustomEvent>` | +| `ionFocus` | Emitted when the select has focus. | `CustomEvent` | ## Methods diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx index d5a4179deb..dadcd45707 100644 --- a/core/src/components/select/select.tsx +++ b/core/src/components/select/select.tsx @@ -107,11 +107,6 @@ export class Select implements ComponentInterface { */ @Event() ionCancel!: EventEmitter; - /** - * Emitted when the overlay is dismissed. - */ - @Event() ionDismiss!: EventEmitter; - /** * Emitted when the select has focus. */ @@ -181,7 +176,6 @@ export class Select implements ComponentInterface { overlay.onDidDismiss().then(() => { this.overlay = undefined; this.isExpanded = false; - this.ionDismiss.emit(); this.setFocus(); }); diff --git a/core/src/components/select/test/basic/e2e.ts b/core/src/components/select/test/basic/e2e.ts index 82246b9d2c..5d0154fd2b 100644 --- a/core/src/components/select/test/basic/e2e.ts +++ b/core/src/components/select/test/basic/e2e.ts @@ -10,10 +10,6 @@ test('select: basic', async () => { // Gender Alert Select let select = await page.find('#gender'); - - // add an event spy to the select - const ionDismiss = await select.spyOnEvent('ionDismiss'); - await select.click(); let alert = await page.find('ion-alert'); @@ -24,8 +20,6 @@ test('select: basic', async () => { await alert.callMethod('dismiss'); - expect(ionDismiss).toHaveReceivedEvent(); - // Skittles Action Sheet Select select = await page.find('#skittles'); await select.click(); @@ -38,8 +32,6 @@ test('select: basic', async () => { await actionSheet.callMethod('dismiss'); - expect(ionDismiss).toHaveReceivedEvent(); - // Custom Alert Select select = await page.find('#customAlertSelect'); await select.click(); @@ -52,8 +44,6 @@ test('select: basic', async () => { await alert.callMethod('dismiss'); - expect(ionDismiss).toHaveReceivedEvent(); - // Custom Popover Select select = await page.find('#customPopoverSelect'); await select.click(); @@ -82,8 +72,6 @@ test('select: basic', async () => { await popover.callMethod('dismiss'); - expect(ionDismiss).toHaveReceivedEvent(); - // Custom Action Sheet Select select = await page.find('#customActionSheetSelect'); await select.click(); @@ -96,8 +84,6 @@ test('select: basic', async () => { await actionSheet.callMethod('dismiss'); - expect(ionDismiss).toHaveReceivedEvent(); - for (const compare of compares) { expect(compare).toMatchScreenshot(); } diff --git a/packages/vue/src/proxies.ts b/packages/vue/src/proxies.ts index 3295aade6a..f265a759a9 100644 --- a/packages/vue/src/proxies.ts +++ b/packages/vue/src/proxies.ts @@ -699,7 +699,6 @@ export const IonSelect = /*@__PURE__*/ defineContainer('ion-selec 'value', 'ionChange', 'ionCancel', - 'ionDismiss', 'ionFocus', 'ionBlur', 'ionStyle'