From 3ecefcbf1eea268b0bd16536bab2cb6ae6d9d565 Mon Sep 17 00:00:00 2001 From: Cam Wiegert Date: Tue, 6 Nov 2018 11:55:34 -0600 Subject: [PATCH] test(menu): add buttons and test push type (#16247) - Augments the menu component's tests to include buttons for non-automated usage - Uses the push type for one of the menus. --- core/src/components/menu/test/basic/e2e.ts | 2 +- .../src/components/menu/test/basic/index.html | 18 ++++++++++++- .../components/menu/test/standalone/e2e.ts | 2 +- .../menu/test/standalone/index.html | 26 ++++++++++++++++++- 4 files changed, 44 insertions(+), 4 deletions(-) diff --git a/core/src/components/menu/test/basic/e2e.ts b/core/src/components/menu/test/basic/e2e.ts index 0318b9abf2..76c3fb5e5a 100644 --- a/core/src/components/menu/test/basic/e2e.ts +++ b/core/src/components/menu/test/basic/e2e.ts @@ -19,7 +19,7 @@ test('menu: basic', async () => { const end = await page.find('ion-menu[side="end"]'); expect(end).toHaveClasses([ - 'menu-type-overlay', + 'menu-type-push', 'menu-enabled', 'menu-side-end' ]); diff --git a/core/src/components/menu/test/basic/index.html b/core/src/components/menu/test/basic/index.html index 47fc27495c..0e66084919 100644 --- a/core/src/components/menu/test/basic/index.html +++ b/core/src/components/menu/test/basic/index.html @@ -29,7 +29,7 @@ - + End Menu @@ -52,10 +52,26 @@ Menu - Basic + + Open Start Menu + Open End Menu + + + diff --git a/core/src/components/menu/test/standalone/e2e.ts b/core/src/components/menu/test/standalone/e2e.ts index 1946c14971..ab2749379a 100644 --- a/core/src/components/menu/test/standalone/e2e.ts +++ b/core/src/components/menu/test/standalone/e2e.ts @@ -19,7 +19,7 @@ test('menu: standalone', async () => { const end = await page.find('ion-menu[side="end"]'); expect(end).toHaveClasses([ - 'menu-type-overlay', + 'menu-type-push', 'menu-enabled', 'menu-side-end' ]); diff --git a/core/src/components/menu/test/standalone/index.html b/core/src/components/menu/test/standalone/index.html index 32c2f2e301..b01834066a 100644 --- a/core/src/components/menu/test/standalone/index.html +++ b/core/src/components/menu/test/standalone/index.html @@ -8,6 +8,14 @@ + @@ -28,7 +36,7 @@ - + End Menu @@ -51,9 +59,25 @@ Menu - Standalone + + Open Start Menu + Open End Menu + + +