javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(segment): change event fires when clicking (#27010)

Browse Source 
resolves #27002
This commit is contained in:
Liam DeBeasi
2023-03-23 16:18:43 -04:00
committed by GitHub
parent 79ba8816f4
commit 3e0a905e81
2 changed files with 31 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/segment/segment.tsx
View File

@ -24,7 +24,6 @@ import type { SegmentChangeEventDetail } from './segment-interface';
})
export class Segment implements ComponentInterface {
private gesture?: Gesture;
private checked?: HTMLIonSegmentButtonElement;
// Value before the segment is dragged
private valueBeforeGesture?: string;
@ -227,6 +226,10 @@ export class Segment implements ComponentInterface {
return Array.from(this.el.querySelectorAll('ion-segment-button'));
}
private get checked() {
return this.getButtons().find((button) => button.value === this.value);
}
/**
* The gesture blocks the segment button ripple. This
* function adds the ripple based on the checked segment
@ -341,9 +344,6 @@ export class Segment implements ComponentInterface {
const index = buttons.findIndex((button) => button.value === this.value);
const next = index + 1;
// Keep track of the currently checked button
this.checked = buttons.find((button) => button.value === this.value);
for (const button of buttons) {
button.classList.remove('segment-button-after-checked');
}
@ -474,8 +474,6 @@ export class Segment implements ComponentInterface {
this.setCheckedClasses();
}
}
this.checked = current;
};
private getSegmentButton = (selector: 'first' | 'last' | 'next' | 'previous'): HTMLIonSegmentButtonElement | null => {
@ -533,7 +531,7 @@ export class Segment implements ComponentInterface {
if (keyDownSelectsButton) {
const previous = this.checked;
this.checkButton(this.checked || current, current);
this.checkButton(previous || current, current);
if (current !== previous) {
this.emitValueChange();
}