From 3d5038ce5caf2be2ae2955c06528c075a1f35951 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 30 Jan 2018 12:22:24 -0500 Subject: [PATCH] style(sass): fix sass lint errors --- packages/core/src/components/chip/chip.ios.scss | 7 +++---- packages/core/src/components/chip/chip.md.scss | 7 +++---- packages/core/src/components/chip/chip.scss | 1 + packages/core/src/components/datetime/datetime.scss | 2 +- packages/core/src/components/fab-button/fab-button.scss | 6 +++--- .../core/src/components/item-divider/item-divider.scss | 2 +- packages/core/src/components/item-group/item-group.scss | 2 +- packages/core/src/components/item/item.scss | 2 +- packages/core/src/components/segment/segment.scss | 2 +- packages/core/src/components/text/text.ios.scss | 2 +- .../core/src/components/virtual-scroll/virtual-scroll.scss | 6 ++++-- 11 files changed, 20 insertions(+), 19 deletions(-) diff --git a/packages/core/src/components/chip/chip.ios.scss b/packages/core/src/components/chip/chip.ios.scss index 816d9d1aeb..13fba1895f 100644 --- a/packages/core/src/components/chip/chip.ios.scss +++ b/packages/core/src/components/chip/chip.ios.scss @@ -23,9 +23,9 @@ } .chip-ios > ion-icon { - background-color: $chip-ios-icon-background-color; - color: $chip-ios-icon-fill-color; + + background-color: $chip-ios-icon-background-color; } .chip-ios ion-avatar { @@ -45,9 +45,8 @@ } .chip-ios .icon-ios-#{$color-name} { - background-color: $color-base; - color: $color-contrast; + background-color: $color-base; } } diff --git a/packages/core/src/components/chip/chip.md.scss b/packages/core/src/components/chip/chip.md.scss index 20b864880d..ef3c659a81 100644 --- a/packages/core/src/components/chip/chip.md.scss +++ b/packages/core/src/components/chip/chip.md.scss @@ -23,9 +23,9 @@ } .chip-md > ion-icon { - background-color: $chip-md-icon-background-color; - color: $chip-md-icon-fill-color; + + background-color: $chip-md-icon-background-color; } .chip-md ion-avatar { @@ -45,9 +45,8 @@ } .chip-md .icon-md-#{$color-name} { - background-color: $color-base; - color: $color-contrast; + background-color: $color-base; } } diff --git a/packages/core/src/components/chip/chip.scss b/packages/core/src/components/chip/chip.scss index 1a8ba2a0cc..01c9adc261 100644 --- a/packages/core/src/components/chip/chip.scss +++ b/packages/core/src/components/chip/chip.scss @@ -18,6 +18,7 @@ ion-chip > ion-icon { @include border-radius($chip-icon-border-radius); display: inline-flex; + align-items: center; justify-content: center; diff --git a/packages/core/src/components/datetime/datetime.scss b/packages/core/src/components/datetime/datetime.scss index 49fd3c9571..68cda8bf89 100644 --- a/packages/core/src/components/datetime/datetime.scss +++ b/packages/core/src/components/datetime/datetime.scss @@ -54,4 +54,4 @@ ion-datetime { .item .datetime { position: static; -} \ No newline at end of file +} diff --git a/packages/core/src/components/fab-button/fab-button.scss b/packages/core/src/components/fab-button/fab-button.scss index e456972dfe..ab793686bc 100755 --- a/packages/core/src/components/fab-button/fab-button.scss +++ b/packages/core/src/components/fab-button/fab-button.scss @@ -16,7 +16,7 @@ width: $fab-size; height: $fab-size; - border: none; + border: 0; font-size: 14px; line-height: $fab-size; @@ -74,10 +74,10 @@ ion-fab-button[mini] .fab-button { .fab-button-close-icon { @include position(0, 0, null, 0); - display: flex; - position: absolute; + display: flex; + height: 100%; opacity: 0; diff --git a/packages/core/src/components/item-divider/item-divider.scss b/packages/core/src/components/item-divider/item-divider.scss index c444db2687..7145b7f4ec 100644 --- a/packages/core/src/components/item-divider/item-divider.scss +++ b/packages/core/src/components/item-divider/item-divider.scss @@ -55,4 +55,4 @@ ion-item-divider[sticky] { align-self: stretch; text-overflow: ellipsis; -} \ No newline at end of file +} diff --git a/packages/core/src/components/item-group/item-group.scss b/packages/core/src/components/item-group/item-group.scss index 758a253b74..4f2c5df800 100644 --- a/packages/core/src/components/item-group/item-group.scss +++ b/packages/core/src/components/item-group/item-group.scss @@ -6,4 +6,4 @@ ion-item-group { display: block; -} \ No newline at end of file +} diff --git a/packages/core/src/components/item/item.scss b/packages/core/src/components/item/item.scss index d407430a65..c1ea3d4f7f 100644 --- a/packages/core/src/components/item/item.scss +++ b/packages/core/src/components/item/item.scss @@ -98,6 +98,6 @@ ion-input.item { } .item > ion-icon, -.item-inner > ion-icon { +.item-inner > ion-icon { font-size: 1.6em; } diff --git a/packages/core/src/components/segment/segment.scss b/packages/core/src/components/segment/segment.scss index d66a0335ab..740cb40b30 100644 --- a/packages/core/src/components/segment/segment.scss +++ b/packages/core/src/components/segment/segment.scss @@ -44,4 +44,4 @@ ion-segment-button { &:focus { outline: none; } -} \ No newline at end of file +} diff --git a/packages/core/src/components/text/text.ios.scss b/packages/core/src/components/text/text.ios.scss index 2a020aba48..58c8c1512e 100644 --- a/packages/core/src/components/text/text.ios.scss +++ b/packages/core/src/components/text/text.ios.scss @@ -11,7 +11,7 @@ .text-ios-#{$color-name}, .text-ios-#{$color-name} a, .text-ios-#{$color-name} p { - color: $color-base !important + color: $color-base !important; } } diff --git a/packages/core/src/components/virtual-scroll/virtual-scroll.scss b/packages/core/src/components/virtual-scroll/virtual-scroll.scss index c3795d9b4a..bd64f5ec7c 100644 --- a/packages/core/src/components/virtual-scroll/virtual-scroll.scss +++ b/packages/core/src/components/virtual-scroll/virtual-scroll.scss @@ -1,8 +1,9 @@ @import "../../themes/ionic.globals"; ion-virtual-scroll { - display: block; position: relative; + display: block; + width: 100%; // contain: strict; @@ -15,7 +16,8 @@ ion-virtual-scroll { .virtual-item { @include position(0, 0, null, 0); - will-change: transform; position: absolute; + + will-change: transform; // contain: strict; }