javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 03:00:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(angular): select method now has correct types (#23953)

Browse Source 
resolves #23952
This commit is contained in:
Liam DeBeasi
2021-09-22 08:51:33 -04:00
committed by GitHub
parent 00269941ca
commit 3c1be89112
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
angular/src/directives/navigation/ion-tabs.ts
View File

@ -87,8 +87,9 @@ export class IonTabs {
* to the default tabRootUrl * to the default tabRootUrl
*/ */
@HostListener('ionTabButtonClick', ['$event']) @HostListener('ionTabButtonClick', ['$event'])
select(ev: CustomEvent) { select(tabOrEvent: string | CustomEvent) {
const tab = ev.detail.tab; const isTabString = typeof tabOrEvent === 'string';
const tab = (isTabString) ? tabOrEvent : (tabOrEvent as CustomEvent).detail.tab;
const alreadySelected = this.outlet.getActiveStackId() === tab; const alreadySelected = this.outlet.getActiveStackId() === tab;
const tabRootUrl = `${this.outlet.tabsPrefix}/${tab}`; const tabRootUrl = `${this.outlet.tabsPrefix}/${tab}`;
@ -98,7 +99,9 @@ export class IonTabs {
* will respond to this event too, causing * will respond to this event too, causing
* the app to get directed to the wrong place. * the app to get directed to the wrong place.
*/ */
ev.stopPropagation(); if (!isTabString) {
(tabOrEvent as CustomEvent).stopPropagation();
}
if (alreadySelected) { if (alreadySelected) {
const activeStackId = this.outlet.getActiveStackId(); const activeStackId = this.outlet.getActiveStackId();